rilmodem/test-sim-online hard-codes 'Serial' match
Bug #1334867 reported by
Tony Espy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ofono (Ubuntu) |
Fix Released
|
Medium
|
Martti Piirainen | ||
Bug Description
Although the rilmodem-specific test-sim-online script has a parameter to indicate it's being run in the emulator, and also match parameters for mnc and mcc ( network code / country code ), it hard-codes the modem 'Serial' ( IMEI ) check against the string "000000000000000".
This was found while testing the silo for the following MR:
https:/
If -e or --eumulator are specified, matching against a pre-defined string is OK. In all other cases -i or --imei should be required.
Also, the wiki-based ofono test plan SIM page should be updated to reflect usage of this script for automation:
Related branches
lp://staging/~phablet-team/ofono/mbpi-nettime-plus-oem-fixes
- Alfonso Sanchez-Beato: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 2623 lines (+1402/-785)24 files modifiedMakefile.am (+6/-3)
debian/changelog (+19/-0)
drivers/infineonmodem/infineon_constants.h (+77/-0)
drivers/rilmodem/sim.c (+68/-1)
drivers/rilmodem/vendor.h (+2/-1)
gril/grilreply.c (+52/-0)
gril/grilreply.h (+10/-0)
gril/grilrequest.c (+15/-0)
gril/grilrequest.h (+3/-0)
gril/parcel.c (+52/-0)
gril/parcel.h (+2/-0)
plugins/android-apndb.c (+0/-494)
plugins/android-apndb.h (+0/-33)
plugins/android-provision.c (+0/-227)
plugins/infineon.c (+76/-0)
plugins/mtk.c (+48/-1)
plugins/ril.c (+33/-24)
plugins/ril.h (+30/-0)
plugins/ubuntu-apndb.c (+596/-0)
plugins/ubuntu-apndb.h (+33/-0)
plugins/ubuntu-provision.c (+150/-0)
test/rilmodem/test-sim-online (+2/-1)
unit/test-grilreply.c (+72/-0)
unit/test-grilrequest.c (+56/-0)
| description: | updated |
| Changed in ofono (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Martti Piirainen (piiramar) |
| importance: | High → Medium |
Revision history for this message
| Martti Piirainen (piiramar) wrote | #1 |
| Changed in ofono (Ubuntu): | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ofono (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This regression (test-sim-online script failing in real HW) will be fixed by oFono pull request https:/
Additionally, the x86 emulator needs a fix to have the test-sim-online script actually pass with the '--emulator' argument given, see https:/
I will update the wiki, too.