| 2014-06-26 21:53:08 |
Tony Espy |
description |
Although the rilmodem-specific test-sim-online script has a parameter to indicate it's being run in the emulator, and also match parameters for mnc and mcc ( network code / country code ), it hard-codes the modem 'Serial' ( IMEI ) check against the string "000000000000000".
This was found while testing the silo for the following MR:
https://code.launchpad.net/~phablet-team/ofono/low-power-mode-et-al/+merge/224347
If -e or --eumulator are specified, matching against a pre-defined string is OK. In all other cases -i or --imei should be required. |
Although the rilmodem-specific test-sim-online script has a parameter to indicate it's being run in the emulator, and also match parameters for mnc and mcc ( network code / country code ), it hard-codes the modem 'Serial' ( IMEI ) check against the string "000000000000000".
This was found while testing the silo for the following MR:
https://code.launchpad.net/~phablet-team/ofono/low-power-mode-et-al/+merge/224347
If -e or --eumulator are specified, matching against a pre-defined string is OK. In all other cases -i or --imei should be required.
Also, the wiki-based ofono test plan SIM page should be updated to reflect usage of this script for automation:
https://wiki.ubuntu.com/Process/Merges/TestPlans/ofono/SIM |
|
