Ubuntu
ofono package

Support /custom/etc/apns-conf.xml

Bug #1315509 reported by Tony Espy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ofono (Ubuntu)
Fix Released
High
Tony Espy

Bug Description

In order to support Carrier customization of apns-conf.xml, ofono should search for /custom/etc/apns-conf.xml first, and if it exists, use it to override APNs found in the default apns-conf.xml.

First the /custom file ( /custom/etc/apns-conf.xml ) is queried. If any mvno apns exist in the results list, all non-mvno apns are removed from the results. Next, the /system file ( /system/etc/apns-conf.xml ) is queried, and the same mvno logic applied to the results.

Finally the two lists are merged. If an apn is found in /custom which matches the type and 'apn' attributes of a /system apn, then the custom one is used.

Note, this would only allow us to add new APNs and/or replace existing APNs in apns-conf.xml. If we need the ability to disable APNs without replacing them, additional logic would be required.

See original description

Related branches

lp://staging/~phablet-team/ofono/mbpi-nettime-plus-oem-fixes
Alfonso Sanchez-Beato: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 2623 lines (+1402/-785)
24 files modified
Makefile.am (+6/-3)
debian/changelog (+19/-0)
drivers/infineonmodem/infineon_constants.h (+77/-0)
drivers/rilmodem/sim.c (+68/-1)
drivers/rilmodem/vendor.h (+2/-1)
gril/grilreply.c (+52/-0)
gril/grilreply.h (+10/-0)
gril/grilrequest.c (+15/-0)
gril/grilrequest.h (+3/-0)
gril/parcel.c (+52/-0)
gril/parcel.h (+2/-0)
plugins/android-apndb.c (+0/-494)
plugins/android-apndb.h (+0/-33)
plugins/android-provision.c (+0/-227)
plugins/infineon.c (+76/-0)
plugins/mtk.c (+48/-1)
plugins/ril.c (+33/-24)
plugins/ril.h (+30/-0)
plugins/ubuntu-apndb.c (+596/-0)
plugins/ubuntu-apndb.h (+33/-0)
plugins/ubuntu-provision.c (+150/-0)
test/rilmodem/test-sim-online (+2/-1)
unit/test-grilreply.c (+72/-0)
unit/test-grilrequest.c (+56/-0)
lp://staging/ubuntu/utopic-proposed/ofono
Tony Espy (awe)
Changed in ofono (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Tony Espy (awe)
Changed in ofono (Ubuntu):
assignee: nobody → Tony Espy (awe)
Tony Espy (awe)
Changed in ofono (Ubuntu):
importance: Wishlist → High
Tony Espy (awe)
Changed in ofono (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Tony Espy (awe) wrote :

This change was merged into our git master. The pull request can be seen here:

https://github.com/rilmodem/ofono/pull/101

Changed in ofono (Ubuntu):
status: In Progress → Fix Committed
summary: - Support /custom/apns-conf.xml
+ Support /custom/etc/apns-conf.xml
Tony Espy (awe)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ofono - 1.12.bzr6870+14.10.20140721-0ubuntu1

---------------
ofono (1.12.bzr6870+14.10.20140721-0ubuntu1) utopic; urgency=medium

  [ Martti Piirainen ]
  * drivers/rilmodem/sim.c: notify on SIM removal (LP: #1332306)
  * unit/rilmodem/test-sim-online: fix serial number check (LP: #1334867)

  [ Alfonso Sanchez-Beato ]
  * plugins/mtk.c: fix race condition when onlining modem
  * build, drivers/infeonmodem, drivers/rilmodem, gril,
    plugins/infeon.c, plugins/ril.*, unit: add Infeon OEM hooks

  [ Tony Espy ]
  * build, plugins/ubuntu-provision.c, ubuntu-apndb.*: re-named
    provisioning plugin code from android-* to ubuntu-*. Also removed
    code that queries mobile-broadband-provider-info's db, and finally
    implemented a /custom hook for custom apn dbs (LP: #1315509).
 -- Ubuntu daily release <email address hidden> Mon, 21 Jul 2014 18:59:17 +0000

Changed in ofono (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.