MAAS

DHCP config doesn't get written unless an inhuman combination of scripts is run

Bug #1044229 reported by Julian Edwards
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Julian Edwards
maas (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When packaging installs maas-dhcp it will run "maas config-master-dhcp" which also sets up the master nodegroup. This will also cause a task to run that generates the dhcpd.conf if the enable_dhcp flag is set.

Problem is, if the flag is not set, then the config is not written and the admin has to either run the script again or run a different script to give sample config output and restart the dhcpd manually.

The solution is to implicitly set the enable_dhcp flag if dhcp parameters are supplied - it's fairly certain that the user wants to set up DHCP.

See original description

Related branches

lp://staging/~julian-edwards/maas/enable_dhcp_when_setting_up_params
Jeroen T. Vermeulen (community): Approve
Diff: 55 lines (+8/-20)
2 files modified
src/maasserver/management/commands/config_master_dhcp.py (+3/-3)
src/maasserver/tests/test_commands_config_master_dhcp.py (+5/-17)
lp://staging/~andreserl/maas/packaging_bzr957
Andres Rodriguez (community): Approve
Diff: 136 lines (+54/-29)
5 files modified
debian/changelog (+2/-0)
debian/maas-dhcp.config (+13/-8)
debian/maas-dhcp.postinst (+22/-19)
debian/maas-dhcp.templates (+8/-0)
debian/maas.prerm (+9/-2)
lp://staging/~andreserl/maas/packaging_bzr971
Andres Rodriguez (community): Approve
Diff: 73 lines (+25/-3)
4 files modified
debian/changelog (+4/-2)
debian/maas-dhcp.config (+2/-0)
debian/maas-dhcp.postinst (+6/-1)
debian/maas-dhcp.templates (+13/-0)
lp://staging/ubuntu/quantal/maas
Julian Edwards (julian-edwards)
Changed in maas:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Packaging is broken here since it installs maas-dhcp when installing maas. maas-dhcp should be optional.

Julian Edwards (julian-edwards)
description: updated
Julian Edwards (julian-edwards)
Changed in maas:
assignee: nobody → Julian Edwards (julian-edwards)
status: Triaged → In Progress
Julian Edwards (julian-edwards)
Changed in maas:
status: In Progress → Fix Released
Revision history for this message
Andres Rodriguez (andreserl) wrote :

The installation of maas-dhcp is optional. It is a recommends. However, maas installs its recommends by default. maas-dhcp should ask whether we want to enable the DHCP server. If so, it will do the configuration.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package maas - 0.1+bzr971+dfsg-0ubuntu1

---------------
maas (0.1+bzr971+dfsg-0ubuntu1) quantal; urgency=low

  * New upstream release (LP: #1044367)

  [ Julian Edwards ]
  * Fix 02-pserv-config.patch to handle new default tftp directory

  [ Andres Rodriguez ]
  * debian/maas.postinst:
    - include '/MAAS' for DEFAULT_MAAS_URL.(LP: #1033956)
    - Update bzr version to safely upgrade.
  * Add maas-dns package that configures DNS in MAAS (LP: #1030860)
  * Remove cobbler related bits
    - debian/maas.postinst: Drop cobbler configuration
    - debian/maas.install: Drop installation of snippets/preseeds.
    - debian/control:
      + Drop Depends on maas-provision. (LP: #975473)
      + Depends on bind9utils.
      + Depends on python-lockfile (LP: #1037400)
      Add necessary Conflicts/Replaces. Add conflicts to tftpd-hpa and dnsmasq.
      Depends on isc-dhcp-server for maas-dhcp, and syslinux-common.
    - debian/extras/maas-provision: Add missing "$@" (LP: #1040462)
    - debian/patches:
      + 02-pserv-config.patch: Updated. Do not patch cobbler related bits.
        patch tftp config to default.
  * maas-dhcp: Re-add to handle initial configuration of MAAS DHCP server.
  * Allow restart of 'isc-dhcp-server' by adding a sudoers file:
    - debian/extras/99-maas-sudoers: Added.
    - debian/maas.install: Install 99-maas-sudoers
  * Minor improvements on dbconfig-common handling:
    - debian/maas.config: Only call dbc_go when scripts present.
    - debian/maas.postrm: Only call dbc_go when config file exists.
  * debian/maas.maas-celery.upstart: Enable Beat and set scheduler db file.
  * debian/maas-dns.postinst: Set correct permissions. (LP: #1042868)
  * debian/maas-dhcp.config:
    - Ask whether we want to enable DHCP (LP: #1044229)
    - Add debconf question for network interfaces
  * debian/maas.prerm: Stop services before removing database (LP: #1044559)
 -- Andres Rodriguez <email address hidden> Thu, 02 Aug 2012 09:01:43 -0400

Changed in maas (Ubuntu):
status: New → Fix Released
Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 1044229] Re: DHCP config doesn't get written unless an inhuman combination of scripts is run

On Tuesday 04 September 2012 15:48:29 you wrote:
> The installation of maas-dhcp is optional. It is a recommends. However,
> maas installs its recommends by default. maas-dhcp should ask whether we
> want to enable the DHCP server. If so, it will do the configuration.

If someone says "no" initially and then wants to configure it later, then do
you mean that they should run dpkg-reconfigure on maas-dhcp?

In fact they can do that or run the same provisioning command that the package
does I guess.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.