Lockscreen caps lock icon drawn under text entry, should be a white icon.
Bug #1307738 reported by
Brandon Schaefer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Brandon Schaefer | ||
7.2 |
Fix Released
|
Medium
|
Brandon Schaefer | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Brandon Schaefer | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Lockscreen caps lock icon drawn under text entry, should be a white icon.
[Inpact]
The old Caps lock icon was rendering below the Text Entry causeing it to grey out. This is hard to see.
[Test case]
1) Press Super + L (lockscreen)
2) Press Caps Lock (unless its already active)
Expected Result:
White Caps lock icon.
[Regression potential]
Very low, worse case the icon doesn't render correctly, yeilding a grey icon.
Related branches
lp://staging/~brandontschaefer/unity/lp.1307738-fix
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
-
Diff: 543 lines (+127/-129)9 files modifiedlockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+0/-1)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+7/-99)
lockscreen/UserPromptView.h (+1/-13)
tests/test_lockscreen_controller.cpp (+0/-1)
unity-shared/TextInput.cpp (+109/-4)
unity-shared/TextInput.h (+10/-3)
lp://staging/~unity-team/unity/7.2.2
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
Superseded
for merging
into
lp://staging/unity
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
Changed in unity: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → In Progress |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
tags: | added: lockscreen |
Changed in unity: | |
milestone: | none → 7.3.0 |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
description: | updated |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
To post a comment you must log in.
This bug was fixed in the package unity - 7.2.0+14. 10.20140606. 1-0ubuntu1
--------------- 14.10.20140606. 1-0ubuntu1) utopic; urgency=low
unity (7.2.0+
[ Alfred Neumayer ]
* Restore the launcher position by reversing the animation and
unsetting the DND_PUSHED_OFF quirk. (LP: #1304882)
[ Brandon Schaefer ] View. (LP: #1308323)
* TextInput: move the warning icon inside the input field, render it
white (LP: #1307738)
* ShutdownView: Scale up the Buttons and Text plus Borders of the
UnityWindow
* Lockscreen warning icon needs a tooltip to say what the warning is
about! (LP: #1308288)
[ Marco Trevisan (Treviño) ] cherIcon: Focus and, in case, Spread the windows on
* ApplicationLaun
DnD After 1 second that an user is over an icon, that icon should
focus the relative application and Spread its windows if it has more
than one opened. Correctly handle the DnD scale in launcher, and
apply glow to the icon under pointer. (LP: #607796)
* SwitcherView: use RawPixel's for the size values and convert them to
match current scaling (LP: #1317348)
[ Chris Townsend ]
* Fix issue where scaling the edge illumination up and down with the
size of the Launcher icons would cause the illumination border to be
offset and smaller than the icon. (LP: #1309739)
-- Ubuntu daily release <email address hidden> Fri, 06 Jun 2014 13:55:32 +0000