Keyboard shortcuts overlay text too long
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
New
|
Undecided
|
Unassigned | ||
Ubuntu Translations |
Fix Released
|
Undecided
|
Unassigned | ||
Unity |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
7.2 |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Inpact]
The shortcut overlay window listes some truncated keybindings and descriptions although there's enough horizontal space to show them all.
[Test case]
The test case for this bug depends a lot on the locale used and thus there's not an universal way to verify it, this is generally valid for English locale but should apply to others as well:
1. In Unity Control Center -> Appearance -> Behavior enable the workspaces
2. Hold down the super key unless the shortcut overlay window is not show (if it's
supported, minimum resolution is 1366x768)
3. Both the keybindings and the descriptions should not be ellipsised if there's enough
horizontal space to present them, for example the "Super + Alt + Cursor ke.."
keybinding should be instead "Super + Alt + Cursor keys"
[Regression potential]
The view might be too large in some locales and thus not to show at all, although we should generally handle this as it used to be before.
----------
When I hold down Super I get a popup image detailing the shortcut keys. There are a few issues with this image which I have filed as separate bugs.
Workspaces Text too long to fit. I see "Super + Alt + Cursor ke.." Which I presume should say "Cursor keys"
Related branches
- Andrea Azzarone (community): Approve
-
Diff: 268 lines (+95/-44)3 files modifiedshortcuts/ShortcutController.cpp (+1/-1)
shortcuts/ShortcutView.cpp (+85/-40)
shortcuts/ShortcutView.h (+9/-3)
- Andrea Azzarone (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 333 lines (+123/-52)3 files modifiedshortcuts/ShortcutController.cpp (+1/-1)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
Changed in unity: | |
status: | New → Confirmed |
tags: | added: needs-design |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
milestone: | none → 7.3.0 |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
description: | updated |
Changed in ubuntu-translations: | |
status: | New → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.