Fullscreen window set to "Always on Top" in single-monitor will hide the lockscreen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
7.2 |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
A fullscreen window set to "always on top" hides the lockscreem.
[Test Case]
(1) Open a video in Totem
(2) Right-click on the titlebar and set Totem to "Always on Top"
(3) Make Totem full screen (eg. with the F11 key or clicking on the control)
(4) Manually Lock the screen using Super+L
(5) The lockscreen should go above the Totem window now.
If you don't lock it manually and just pause the video and let it lock automatically this will show the same behavior.
The same behavior occurs with any application that can enter full screen mode.
[Regression Potential]Two cases may potentially source regressions.
(1) windows that need to appear above the lockscreen, such as on-screen keyboards,(2) applications presenting fullscreen windows using unusual or non-standard toolkits.It is unlikely that regressions in either of these cases would be introduced by this bug fix, but rather would be pre-existing problems not fixed here.
(3) Indicator menus might be not being drawn
Related branches
- Brandon Schaefer (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 187 lines (+42/-32)2 files modifiedplugins/unityshell/src/unityshell.cpp (+40/-32)
plugins/unityshell/src/unityshell.h (+2/-0)
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
description: | updated |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
description: | updated |
description: | updated |
Changed in unity: | |
milestone: | 7.2.1 → 7.3.0 |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
status: | Fix Committed → Fix Released |
description: | updated |
Thank you for your bug report. I can't confirm that issue here though