Invoking obsolete 'firmware_install' target breaks snap build
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Impact:
The snapcraft.yaml in bionic/master invokes the now obsolete 'firmware_install' target that was removed in 5620a0d1aacd554
On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft:
linux $ snapcraft
...
make -j4 bzImage modules
...
LD [M] virt/lib/
make: *** No rule to make target 'firmware_install'. Stop.
make: *** Waiting for unfinished jobs....
INSTALL arch/x86/
...
make -j4 CONFIG_
Failed to run 'make -j4 CONFIG_
Verify that the part is using the correct parameters and try again.
Fix:
Since firmware files were removed from the Linux source code, and we rely on files provided by the linux-firmware package, skip invoking 'firmware_install' altogether and fix the build.
linux $ snapcraft
...
Staging kernel
Staging firmware
Priming kernel
Priming firmware
Determining the version from the project repo (version-script).
The version has been set to '4.15.0-24.26'
Snapping 'pc-kernel' |
Snapped pc-kernel_
linux $
Regression risk:
None since the patch only modifies the snapcraft.yaml file.
description: | updated |
description: | updated |
tags: | added: patch |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu): | |
status: | Incomplete → Fix Committed |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1782166
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.