Activity log for bug #1782166

Date Who What changed Old value New value Message
2018-07-17 14:04:13 Paolo Pisati bug added bug
2018-07-17 14:04:19 Paolo Pisati nominated for series Ubuntu Bionic
2018-07-17 14:04:37 Paolo Pisati attachment added 0001-UBUNTU-snapcraft.yaml-stop-invoking-the-obsolete-and.patch https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1782166/+attachment/5164548/+files/0001-UBUNTU-snapcraft.yaml-stop-invoking-the-obsolete-and.patch
2018-07-17 14:30:06 Ubuntu Kernel Bot linux (Ubuntu): status New Incomplete
2018-07-17 14:36:04 Paolo Pisati description Impact: The snapcraft.yaml in bionic/master still invokes the obsolete 'firmware_install' target that was removed in 5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel firmware"), and by invoking a non existin target, snap build fails. On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft: linux $ snapcraft ... make -j4 bzImage modules ... LD [M] virt/lib/irqbypass.ko make: *** No rule to make target 'firmware_install'. Stop. make: *** Waiting for unfinished jobs.... INSTALL arch/x86/crypto/blowfish-x86_64.ko ... make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware Failed to run 'make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2. Verify that the part is using the correct parameters and try again. Fix: Stop invoking a non existing target by applying the attached patch. $ snapcraft ... Regression risk: None since the patch only modifies the snapcraft.yaml file. Impact: The snapcraft.yaml in bionic/master invokes the now obsolete 'firmware_install' target that was removed in 5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel firmware"), and by invoking a non existing target, it fails to build. On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft: linux $ snapcraft ... make -j4 bzImage modules ...   LD [M] virt/lib/irqbypass.ko make: *** No rule to make target 'firmware_install'. Stop. make: *** Waiting for unfinished jobs....   INSTALL arch/x86/crypto/blowfish-x86_64.ko ... make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware Failed to run 'make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2. Verify that the part is using the correct parameters and try again. Fix: Since firmware files were removed from the Linux source code, and we rely on files provided by the linux-firmware package, skip invoking 'firmware_install' altogether and fix the build. linux $ snapcraft ... Staging kernel Staging firmware Priming kernel Priming firmware Determining the version from the project repo (version-script). The version has been set to '4.15.0-24.26' Snapping 'pc-kernel' | Snapped pc-kernel_4.15.0-24.26_amd64.snap linux $ Regression risk: None since the patch only modifies the snapcraft.yaml file.
2018-07-17 14:53:30 Paolo Pisati description Impact: The snapcraft.yaml in bionic/master invokes the now obsolete 'firmware_install' target that was removed in 5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel firmware"), and by invoking a non existing target, it fails to build. On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft: linux $ snapcraft ... make -j4 bzImage modules ...   LD [M] virt/lib/irqbypass.ko make: *** No rule to make target 'firmware_install'. Stop. make: *** Waiting for unfinished jobs....   INSTALL arch/x86/crypto/blowfish-x86_64.ko ... make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware Failed to run 'make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2. Verify that the part is using the correct parameters and try again. Fix: Since firmware files were removed from the Linux source code, and we rely on files provided by the linux-firmware package, skip invoking 'firmware_install' altogether and fix the build. linux $ snapcraft ... Staging kernel Staging firmware Priming kernel Priming firmware Determining the version from the project repo (version-script). The version has been set to '4.15.0-24.26' Snapping 'pc-kernel' | Snapped pc-kernel_4.15.0-24.26_amd64.snap linux $ Regression risk: None since the patch only modifies the snapcraft.yaml file. Impact: The snapcraft.yaml in bionic/master invokes the now obsolete 'firmware_install' target that was removed in 5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel firmware"), and by invoking a non existing target, it breaks the build process. On a generic amd64 environment, check out the Bionic/generic tree, cd into it and execute snapcraft: linux $ snapcraft ... make -j4 bzImage modules ...   LD [M] virt/lib/irqbypass.ko make: *** No rule to make target 'firmware_install'. Stop. make: *** Waiting for unfinished jobs....   INSTALL arch/x86/crypto/blowfish-x86_64.ko ... make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware Failed to run 'make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install firmware_install INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2. Verify that the part is using the correct parameters and try again. Fix: Since firmware files were removed from the Linux source code, and we rely on files provided by the linux-firmware package, skip invoking 'firmware_install' altogether and fix the build. linux $ snapcraft ... Staging kernel Staging firmware Priming kernel Priming firmware Determining the version from the project repo (version-script). The version has been set to '4.15.0-24.26' Snapping 'pc-kernel' | Snapped pc-kernel_4.15.0-24.26_amd64.snap linux $ Regression risk: None since the patch only modifies the snapcraft.yaml file.
2018-07-17 16:25:13 Ubuntu Foundations Team Bug Bot tags patch
2018-07-17 16:25:14 Ubuntu Foundations Team Bug Bot bug added subscriber Joseph Salisbury
2018-07-18 14:13:10 Kleber Sacilotto de Souza bug task added linux (Ubuntu Bionic)
2018-07-18 14:15:27 Kleber Sacilotto de Souza linux (Ubuntu Bionic): status New In Progress
2018-07-25 05:37:37 Khaled El Mously linux (Ubuntu Bionic): status In Progress Fix Committed
2018-08-01 12:47:50 Seth Forshee linux (Ubuntu): status Incomplete Fix Committed
2018-08-07 14:01:53 Brad Figg tags patch patch verification-needed-bionic
2018-08-16 13:27:56 Launchpad Janitor linux (Ubuntu): status Fix Committed Fix Released
2018-08-16 13:27:56 Launchpad Janitor cve linked 2018-12233
2018-08-16 13:27:56 Launchpad Janitor cve linked 2018-13094
2018-08-21 12:29:44 Kleber Sacilotto de Souza tags patch verification-needed-bionic patch verification-done-bionic
2018-08-23 13:23:09 Launchpad Janitor linux (Ubuntu Bionic): status Fix Committed Fix Released
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-10323
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-10840
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-10881
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-1108
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-11412
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-11506
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-12232
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-12904
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-13405
2018-08-23 13:23:09 Launchpad Janitor cve linked 2018-13406