[tabs] Tabs should only be navigated by swiping or tapping on the header area
Bug #1166709 reported by
Calum Pringle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Tim Peeters | ||
Ubuntu UX |
Fix Released
|
High
|
Calum Pringle | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Raring |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Both tapping on and swiping over the header (with tabs) provides quick access to your app’s views. If the quantity of tabs extend beyond screen width, the header scrolls.
The tabs are ONLY navigated by swiping or tapping on the header. NOT by swiping the canvas of the app
Related branches
lp://staging/~tpeeters/ubuntu-ui-toolkit/tabfix
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 483 lines (+236/-83)6 files modifiedmodules/Ubuntu/Components/Tab.qml (+2/-0)
modules/Ubuntu/Components/Tabs.qml (+50/-11)
tests/resources/tabs/MyCustomPage.qml (+50/-0)
tests/resources/tabs/Tabs.qml (+99/-0)
themes/Ambiance/qmltheme/NewTabBar.qml (+30/-19)
themes/Ambiance/qmltheme/NewTabsDelegate.qml (+5/-53)
Changed in ubuntu-ux: | |
assignee: | nobody → Calum Pringle (calumpringle) |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ux: | |
importance: | Undecided → High |
summary: |
- [tabs] Navigate tabs through header + [tabs] Tabs should only be navigated by swiping or tapping on the header + area |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
Changed in ubuntu-ui-toolkit: | |
status: | New → Incomplete |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
status: | Incomplete → Fix Committed |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Some questions:
1. The behavior of the header stays the same (for now)?
2. Can you comment in the bug report what is the behavior for calendar? Maybe I'll have to check the code when I remove the canvas swipe to ensure that the behavior there will still be possible
3. What about animations when switching tabs? Should stay the same? or a cross-fade? (the way we have the tabs in the header
now there is not really a fixed order from left-to-right because any tab may be listed as the first one)
4. The "classic" tabs are still in the code somewhere, but never used. I guess it is safe to remove them completely. Am I correct?