Comment 4 for bug 1187583

Revision history for this message
Michael Chapman (michaeltchapman) wrote : Re: [Bug 1187583] Re: manifests are accessing root level templates

I think core.pp, cobbler_node.pp and any templates required by either
should be in a separate module, not in manifests.

I would prefer the only thing in manifests to be site.pp.

 - Michael

On 6/06/13 3:10 AM, "Dan Bode" <email address hidden> wrote:

>in my case, it's just a pain to have to copy this extra template around.
>I saw backwards compatibility issues between 2.7 and 3.2 (I have to set
>templatedir in 3.2 explicitly). Research showed that this practice is no
>longer recommended by PuppetLabs which means that we should not be doing
>it (b/c it may not be supported, or may lead to unexpected behavior). It
>would be really easy to not do it and replace the template call with a
>string.
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1187583
>
>Title:
> manifests are accessing root level templates
>
>Status in Openstack @ Cisco:
> New
>Status in Cisco Openstack grizzly series:
> Confirmed
>
>Bug description:
> Currently, the cobbler-node.pp file is accessing a root level
> template:
>
> $interfaces_file=regsubst(template("interfaces.erb"), '$',
> "\\n\\", "G")
>
> This is problematic for several reasons, it requires that an extra
> templates directory be managed, and it is no longer recommended:
>
> http://docs.puppetlabs.com/guides/templating.html
>
> I am seeing specific issues
>
> it looks like this is the only place where this template is used, this
> line should be replaces with a static string.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/openstack-cisco/+bug/1187583/+subscriptions