mail out incremental changes when a branch under review is updated

Agreed

This could easily be a cause of unwanted email, if every time the branch is pushed to, new interdiffs are emailed.

On Fri, 2009-11-20 at 14:21 +0000, Aaron Bentley wrote:
> This could easily be a cause of unwanted email, if every time the branch
> is pushed to, new interdiffs are emailed.

John suggests having a button to trigger this.

I think that the resubmit button could be repurposed, as at the moment
losing the conversation history is a misfeature for most folk I know.

I will note though, that you don't have to push on every commit :).

Oh, and the moving diff should be the diff between the previews, not the
changes along the branch - so merges from trunk and other 'things are
not changed' pushes /will not/ trigger mail anyway, as the preview won't
change.

-Rob

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Fri, 2009-11-20 at 14:21 +0000, Aaron Bentley wrote:
>> This could easily be a cause of unwanted email, if every time the branch
>> is pushed to, new interdiffs are emailed.
>
> John suggests having a button to trigger this.
>
> I think that the resubmit button could be repurposed, as at the moment
> losing the conversation history is a misfeature for most folk I know.

We plan to show the conversation from previous merge proposals. I don't
think changing the meaning of resubmit would work.

> I will note though, that you don't have to push on every commit :).
>
> Oh, and the moving diff should be the diff between the previews

You mean a diff of the past and present preview diffs?

, not the
> changes along the branch - so merges from trunk and other 'things are
> not changed' pushes /will not/ trigger mail anyway, as the preview won't
> change.

I don't follow. Diffs include line numbers and context-- these may both
change when the target branch is merged into the source branch.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksG+j0ACgkQ0F+nu1YWqI2JUACfUDewkv77lZTUrM3mO6ZQivVn
U04An2oDBHqMNzqo1InFjKhdD7nJlob2
=fy+f
-----END PGP SIGNATURE-----

On Fri, 2009-11-20 at 20:21 +0000, Aaron Bentley wrote:
>
> > Oh, and the moving diff should be the diff between the previews
>
> You mean a diff of the past and present preview diffs?

Yes.

> , not the
> > changes along the branch - so merges from trunk and other 'things
> are
> > not changed' pushes /will not/ trigger mail anyway, as the preview
> won't
> > change.
>
> I don't follow. Diffs include line numbers and context-- these may
> both
> change when the target branch is merged into the source branch.

Well they may, but perhaps we shouldn't treat simple fuzz as 'changing'
for this case. We could certainly see how much they fluctuate before
deciding that we'd want to put more time into writing a more complex
system.

-Rob

I have some concern that interdiffs are harder to review than the overall proposal diff.

Perhaps we need to distinguish "someone changed this branch you're involved with" from "review is now wanted on
this patch", with the second manually triggered?

Not sure.

IIUC Aaron wrote a bzr plugin to support this, and glued it into LP, but its been disabled due to some misbehaviour.