No email notification about new revisions for an MP (particularly after approval)

Bug #608354 reported by Данило Шеган
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Today, when a new revision is added to a branch after MP is approved, a note about it is added to the actual MP page. However, this triggers no notification to the reviewer, and I think it'd be great to send out an email noting a change to the MP in this way (or at least, I haven't seen it work like this).

Bonus points for including a diff in the email straight away — that would be seriously great!

See also bug 336439 about notifying on conflicts.

Paul Hummer (rockstar)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Wishlist
tags: added: code-review
Revision history for this message
Данило Шеган (danilo) wrote :

Just to add one more thing: big changes (i.e. merging trunk) should probably not include a diff.

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 608354] Re: Email about new revisions for an MP after approval proposal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/23/2010 05:58 AM, Данило Шеган wrote:
> Just to add one more thing: big changes (i.e. merging trunk) should
> probably not include a diff.

I've written an incremental differ that we'll be using to ignore changes
merged from trunk and the prerequisite branch. But if there are other
large changes, I think it's a good idea to warn reviewers, because
something fishy is going on.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxJlXIACgkQ0F+nu1YWqI2gJwCfRHEeRDJb5Lan63TIEZubGLJC
ZaEAnAw23p9l/OO07Mu4yK76X7pEhQEX
=KdsW
-----END PGP SIGNATURE-----

description: updated
Changed in launchpad:
importance: Wishlist → Low
summary: - Email about new revisions for an MP after approval proposal
+ No email notification about new revisions for an MP (particularly after
+ approval)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.