With Chris' responses above addressed (I checked r135)
I do wonder how get_arch() can return invalid responses?
#1
Can you perhaps add a comment explaining under what circumstances you expect an invalid response, in case someone's actually having to debug something similar later?
Should we log this case?
Looks good to me, with these issues addressed... +1
With Chris' responses above addressed (I checked r135)
I do wonder how get_arch() can return invalid responses?
#1
Can you perhaps add a comment explaining under what circumstances you expect an invalid response, in case someone's actually having to debug something similar later?
Should we log this case?
Looks good to me, with these issues addressed... +1