I ran the proposed patch through a screen reader (in this case, Microsoft Narrator) and it didn't result in the modal's title being read.
I think the canonical way to fix this is to use NgbModalOptions' ariaLabelledBy parameter to direct screen readers at elements that have the appropriate label.
I ran the proposed patch through a screen reader (in this case, Microsoft Narrator) and it didn't result in the modal's title being read.
I think the canonical way to fix this is to use NgbModalOptions' ariaLabelledBy parameter to direct screen readers at elements that have the appropriate label.