Evergreen

Screenreader Form Fix - Modal Headers (Angular)

Bug #1950510 reported by Kyle Huckins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Medium
Unassigned

Bug Description

This carries off from lp1615805(https://bugs.launchpad.net/evergreen/+bug/1615805)

When opening a IDL Editor modal, the modal's header is not dictated. This could cause confusion for screenreader users.

See original description
Revision history for this message
Kyle Huckins (khuckins) wrote :

This seems to affect modals in general, so I'm renaming the bug

summary: - Screenreader Form Fix - Record Editor UI (Angular)
+ Screenreader Form Fix - Modal Headers (Angular)
Kyle Huckins (khuckins)
description: updated
Revision history for this message
MaryAnn Alexander (maryann-alexander) wrote :

A fix for record for the record editor UI is available at the tip of:

working/user/malexander/lp1942645-term-name-uniqueness / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/malexander/lp1950510-screenreader-modal-headers-accessibility

Kyle Huckins (khuckins)
tags: added: pullrequest
Revision history for this message
Garry Collum (gcollum) wrote :

A signed-off branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1950510-screenreader-modal-headers-accessibility-signoff

Although I can't test with a screen reader, I do see the <h4> tag with the proper classes when I use inspect while viewing the record editor in Standing Penality and in Shelving Location Groups.

tags: added: signedoff
Terran McCanna (tmccanna)
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 3.9.2
Revision history for this message
Galen Charlton (gmc) wrote :

I ran the proposed patch through a screen reader (in this case, Microsoft Narrator) and it didn't result in the modal's title being read.

I think the canonical way to fix this is to use NgbModalOptions' ariaLabelledBy parameter to direct screen readers at elements that have the appropriate label.

tags: added: needswork
removed: pullrequest signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

(Noting that I did a bit of experimentation with the ariaLabelledBy option and it worked; just a matter of systematically dealing with it for the various components that open NgbModals.)

Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.9.2 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.