Comment 9 for bug 2024188

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
I've had a brief look at this while at patch piloting.
And I'm aware this got auto-subscribed - so it might not have been meant to be ready yet.
But a few questions:

It is marked fix released for octavia and only targeted at jammy so far.
But are you sure this is not also needed for mantic/lunar.

If not, then it would be helpful to state here why maybe?

$ git show pkg/ubuntu/lunar-devel:octavia_dashboard/static/dashboard/project/lbaasv2/workflow/members/members.html | grep 'popover.*memberDetailsForm'
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}">
                                                                                                                                    ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}">
                                                                                                                                                             ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}">

$ git show pkg/ubuntu/mantic-devel:octavia_dashboard/static/dashboard/project/lbaasv2/workflow/members/members.html | grep 'popover.*memberDetailsForm'
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}">
                                                                                                                                    ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}">
                                                                                                                                                             ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}">

Furthermore, you have the (cherry picked from commit ...) statements from what seems to be combining many. I think many would appreciate to be able to follow your thought by adding proper dep-3 header statements like
Origin: backport, https://opendev.org/openstack/octavia-dashboard/commit/9cc4bfac58b901b32c58d36ffab3585645f79be5