[SRU][octavia-dashboard] Add members to pool horizon pane rendering incorrectly

Adding my comments from storyboard:

--

I've just upgraded to 114.0.5735.133-1 and now it's broken. I see the same issue
All the other forms in horizon look alright, I would not blame chrome.

--

I think it's related to a new feature in google chrome:
https://developer.chrome.com/blog/introducing-popover-api

some folks have reported issues https://support.google.com/chrome/thread/218644651/bug-after-updating-google-chrome-to-version-114-0-5735-90?hl=en

this feature adds a default style for a "popover" attribute but this attribute was already used in octavia-dashboard.
in the devtools if I remove the popover attribute from the input boxes, it fixes the form.

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/octavia-dashboard/+/886255

proposed a WIP patch, it works for me but I will ask Horizon experts to confirm that the fix is correct.

Hi, this bug was fixing?

I see the merge, don't know why this issue didn't autoclose.

The attachment "lp2024188-octavia-dashboard.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Hi,
I've had a brief look at this while at patch piloting.
And I'm aware this got auto-subscribed - so it might not have been meant to be ready yet.
But a few questions:

It is marked fix released for octavia and only targeted at jammy so far.
But are you sure this is not also needed for mantic/lunar.

If not, then it would be helpful to state here why maybe?

$ git show pkg/ubuntu/lunar-devel:octavia_dashboard/static/dashboard/project/lbaasv2/workflow/members/members.html | grep 'popover.*memberDetailsForm'
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}">
                                                                                                                                    ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}">
                                                                                                                                                             ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}">

$ git show pkg/ubuntu/mantic-devel:octavia_dashboard/static/dashboard/project/lbaasv2/workflow/members/members.html | grep 'popover.*memberDetailsForm'
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-address'].$invalid && memberDetailsForm[row.id + '-address'].$dirty ? ctrl.ipError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-port'].$invalid && memberDetailsForm[row.id + '-port'].$dirty ? ctrl.portError : '' $}">
                       ng-attr-popover="{$ memberDetailsForm[row.id + '-weight'].$invalid && memberDetailsForm[row.id + '-weight'].$dirty ? ctrl.weightError : '' $}">
                                                                                                                                    ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-address'].$invalid && memberDetailsForm[row.id + '-monitor-address'].$dirty ? ctrl.ipError : '' $}">
                                                                                                                                                             ng-attr-popover="{$ memberDetailsForm[row.id + '-monitor-port'].$invalid && memberDetailsForm[row.id + '-monitor-port'].$dirty ? ctrl.portError : '' $}">

Furthermore, you have the (cherry picked from commit ...) statements from what seems to be combining many. I think many would appreciate to be able to follow your thought by adding proper dep-3 header statements like
Origin: backport, https://opendev.org/openstack/octavia-dashboard/commit/9cc4bfac58b901b32c58d36ffab3585645f79be5

We have the following versions in Jammy Cloud Archive:

Antelope (Lunar): 11.0.0-0ubuntu1~cloud0
Zed (Kinetic): 10.0.0-0ubuntu1~cloud0
Yoga (Jammy): 9.0.0-0ubuntu1.1 500

The patch was merged upstream to all releases from Focal (focal-updates) to Bobcat (devel) and is not includes in any point-releases (tags) so if we want to get it into jammy-updates/Yoga UCA we need to SRU in the following order: Mantic, Lunar, Antelope UCA, Zed UCA, Jammy, Yoga UCA. That was my bad I will add the correct targets to this LP bug.

Thank you for adding the additional bug tasks!

I see the previous suggestions from comment #9 have not been addressed (see DEP-3 info: https://dep-team.pages.debian.net/deps/dep3/) and we're also lacking patches/debdiffs for the other series (besides Jammy).

So I'm unsubscribing ~ubuntu-sponsors for now. Please re-subscribe this team, once the patches are ready for sponsorship.

Debdiff for octavia-dashboard on Jammy-Antelope UCA

  Debdiff for octavia-dashboard on Jammy-Bobcat UCA

Debdiff for octavia-dashboard on Jammy-Zed UCA

Debdiff for octavia-dashboard on Lunar

Debdiff for octavia-dashboard on Mantic

Debdiff for octavia-dashboard on Jammy

I have re-subscribed ~ubuntu-sponsors as the patches are ready for review/sponsorship.

The issues were adressed on comment #9 on my comment #17 with a new patch, effectively the patch on comment #7 can be ignored (maybe deleted?)

I have uploaded a new set of patches for octavia-dashboard addressing the following releases:
Jammy: lp2024188-jammy-octavia-dashboard.debdiff (improvement from my attachment on comment #7)
Jammy-Antelope UCA: lp2024188-jammy-antelope-octavia-dashboard.debdiff
Jammy-Bobcat UCA: lp2024188-jammy-bobcat-octavia-dashboard.debdiff
Jammy-Zed UCA: lp2024188-jammy-zed-octavia-dashboard.debdiff
Lunar: lp2024188-lunar-octavia-dashboard.debdiff
Mantic: lp-2024188-mantic-octavia-dashboard.debdiff

Thanks David and Gregory. New package versions with this fix have been uploaded to the jammy unappoved queue and cloud-archive staging ppas.

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/octavia-dashboard/11.0.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/octavia-dashboard/9.0.0-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

This issue was fixed in the openstack/octavia-dashboard 12.0.0.0rc1 release candidate.

Removing sponsors since the upload was done.

I have tested the jammy octavia-dashboard -proposed package by deploying an openstack cloud with jammy/yoga, I ensured that the issue still exists by following the test plan, I have verified that it was not working with google-chrome, then I proceeded to upgrade the octavia-dashboard package: https://pastebin.ubuntu.com/p/vTdYjH8QDh/

After I upgraded and did a refresh on the google-chrome browser, I could see again the pool member fields being correctly rendered.

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into antelope-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:antelope-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-antelope-needed to verification-antelope-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-antelope-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into zed-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:zed-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-zed-needed to verification-zed-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-zed-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into yoga-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:yoga-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-yoga-needed to verification-yoga-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-yoga-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I have tested the lunar octavia-dashboard -proposed package by deploying an openstack cloud with jammy/yoga, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package: https://pastebin.ubuntu.com/p/4qZN859xYt/

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

I have tested the yoga octavia-dashboard UCA -proposed package by deploying an openstack cloud with focal/yoga, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package: https://pastebin.ubuntu.com/p/C7nJH4ySHH/

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

I have tested the zed octavia-dashboard UCA -proposed package by deploying an openstack cloud with jammy/zed, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package: https://pastebin.ubuntu.com/p/YSXtDnGdb5/

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

I have tested the antelope octavia-dashboard UCA -proposed package by deploying an openstack cloud with jammy/antelope, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package:
https://pastebin.ubuntu.com/p/8W7g9DyFzr/

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package octavia-dashboard - 11.0.0-0ubuntu1.1~cloud0
---------------

 octavia-dashboard (11.0.0-0ubuntu1.1~cloud0) jammy-antelope; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 octavia-dashboard (11.0.0-0ubuntu1.1) lunar; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/2023.1 branch.
 .
   [ David Negreira ]
   * d/p/fix-popover-attributes.patch: Fix popover attributes in member add
     dialog. Using popovers in the member table is broken in chrome 114,
     because of their new "popover" feature (LP: #2024188).

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package octavia-dashboard - 10.0.0-0ubuntu1~cloud1
---------------

 octavia-dashboard (10.0.0-0ubuntu1~cloud1) jammy-zed; urgency=medium
 .
   [ Corey Bryant ]
   * d/gbp.conf: Create stable/zed branch.
 .
   [ David Negreira ]
   * d/p/fix-popover-attributes.patch: Fix popover attributes in member add
     dialog. Using popovers in the member table is broken in chrome 114,
     because of their new "popover" feature (LP: #2024188).

This bug was fixed in the package octavia-dashboard - 11.0.0-0ubuntu1.1

---------------
octavia-dashboard (11.0.0-0ubuntu1.1) lunar; urgency=medium

  [ Corey Bryant ]
  * d/gbp.conf: Create stable/2023.1 branch.

  [ David Negreira ]
  * d/p/fix-popover-attributes.patch: Fix popover attributes in member add
    dialog. Using popovers in the member table is broken in chrome 114,
    because of their new "popover" feature (LP: #2024188).

 -- David Negreira <email address hidden> Thu, 07 Sep 2023 07:41:46 +0000

This bug was fixed in the package octavia-dashboard - 9.0.0-0ubuntu1.2

---------------
octavia-dashboard (9.0.0-0ubuntu1.2) jammy; urgency=medium

  [ David Negreira ]
  * d/p/fix-popover-attributes.patch: Fix popover attributes in member add
    dialog. Using popovers in the member table is broken in chrome 114,
    because of their new "popover" feature (LP: #2024188).

 -- David Negreira <email address hidden> Thu, 07 Sep 2023 09:21:27 +0000

The verification of the Stable Release Update for octavia-dashboard has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package octavia-dashboard - 9.0.0-0ubuntu1.2~cloud0
---------------

 octavia-dashboard (9.0.0-0ubuntu1.2~cloud0) focal-yoga; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 octavia-dashboard (9.0.0-0ubuntu1.2) jammy; urgency=medium
 .
   [ David Negreira ]
   * d/p/fix-popover-attributes.patch: Fix popover attributes in member add
     dialog. Using popovers in the member table is broken in chrome 114,
     because of their new "popover" feature (LP: #2024188).

This issue was fixed in the openstack/octavia-dashboard 9.0.1 release.

Hi,

I have attached 4 more debdiffs in order to backport the fix to Ussuri:
lp2024188-focal-octavia-dashboard.debdiff for Ubuntu - It's the backport patch to Ussuri
lp2024188-focal-victoria-octavia-dashboard.debdiff for UCA - It's the backport patch to focal-victoria
lp2024188-focal-wallaby-octavia-dashboard.debdiff for UCA - It's the backport patch to focal-wallaby
lp2024188-focal-xena-octavia-dashboard.debdiff for UCA - It's the backport patch to focal-xena

These are the last sets of backports for this issue that are needed. Thanks everyone.

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into xena-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:xena-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-xena-needed to verification-xena-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-xena-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Thanks David. Uploaded to focal unapproved queue: https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=octavia-dashboard

I have tested the xena octavia-dashboard UCA -proposed package by deploying an openstack cloud with focal/xena, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package.

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

I have tested the wallaby octavia-dashboard UCA -proposed package by deploying an openstack cloud with focal/wallaby, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package.

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

I have tested the victoria octavia-dashboard UCA -proposed package by deploying an openstack cloud with focal/victoria, I ensured that the issue still exists by following the test plan, I have verified that it was not working with latest google-chrome, then I proceeded to upgrade the octavia-dashboard package.

After I upgraded, and did a refresh on google-chrome-browser, I could see again the pool member fields being correctly rendered.

Hello Gregory, or anyone else affected,

Accepted octavia-dashboard into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/octavia-dashboard/5.0.0-0ubuntu0.20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.