© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4b6b663
demo site
(Get the code!)
Hey, Nate!
First of all, thanks for submitting a Discourse charm to the Charm Store. I believe it will be a great addition to the current collection of charms.
I have taken a first look at the branch and have found a couple things:
* It does not have tests. Currently, charms proposed for trusty need to have tests in order to be included on the charm store.
* config.yaml values don't contain a default value. In order for `charm proof`, our linting tool, to pass, all values in config.yaml must contain a default. You can use `default: "" ` for blank and `default:` for a NoneType value.
* It needs to contain a copyright file, and needs to be licensed under an open source license
Based on that, I am moving this bug to 'Incomplete'. Please move it to New or Fix Committed once it's ready for another review. Thanks again for your efforts in the Discourse charm!