New Charm: Discourse

Hey, Nate!

First of all, thanks for submitting a Discourse charm to the Charm Store. I believe it will be a great addition to the current collection of charms.

I have taken a first look at the branch and have found a couple things:

 * It does not have tests. Currently, charms proposed for trusty need to have tests in order to be included on the charm store.
 * config.yaml values don't contain a default value. In order for `charm proof`, our linting tool, to pass, all values in config.yaml must contain a default. You can use `default: "" ` for blank and `default:` for a NoneType value.
 * It needs to contain a copyright file, and needs to be licensed under an open source license

Based on that, I am moving this bug to 'Incomplete'. Please move it to New or Fix Committed once it's ready for another review. Thanks again for your efforts in the Discourse charm!

Thanks. I didn't realize warnings were show-stoppers, or I would have fixed them.

I'm not really sure how to write tests for this code. The code installs aufs, docker, git, and deploys a docker container.... how would you suggest I test that? I can add tests for merging the config settings with the on-disk yaml file, but I'm not really sure how to test that docker is properly installed (I guess I could just try running docker --help and make sure it outputs something sane?)

Help on how to test would be much appreciated.

Hey Nate,

Sorry for not linking before, I totally missed it! We would need testing in order to check that the hooks run correctly, and you would probably want to check that the site is up, as well as some basic relations (probably haproxy since it's a website?).

We have Amulet, a testing tool, in order to give you a hand with that. You may be able to find more information about Amulet and how to write tests with it here: https://juju.ubuntu.com/docs/tools-amulet.html

Please, let me know if there's anything else you may need a hand with. You can also email <email address hidden> or go to #juju on irc.freenode.net - my nick is jose there.