[launcher] Tile Progress bar starting from left of launcher, not container
Bug #912777 reported by
Gerry Boland
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-2d |
Fix Released
|
Low
|
Paweł Stołowski | ||
unity-2d (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Best to check out the screenshot to see what I mean.
I started to burn a CR with Brasero, and I noted that the progress bar begins at the left of the launcher, not within the tile itself.
Related branches
lp://staging/~stolowski/unity-2d/fix-912777
- Gerry Boland (community): Approve
- Michał Sawicz: Needs Fixing
-
Diff: 294 lines (+257/-1)5 files modifiedlibunity-2d-private/src/application.cpp (+7/-0)
tests/README (+3/-1)
tests/launcher/launcher_item_progress.rb (+144/-0)
tests/misc/fake_progress.py (+61/-0)
tests/misc/lib/launchercli.rb (+42/-0)
Changed in unity-2d: | |
milestone: | none → 5.6 |
Changed in unity-2d: | |
assignee: | nobody → Pawel Stolowski (stolowski) |
Changed in unity-2d: | |
milestone: | 5.6 → 5.8 |
Changed in unity-2d: | |
status: | Confirmed → Fix Committed |
Changed in unity-2d: | |
milestone: | 5.8 → 5.7 |
Changed in unity-2d: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Problem caused by Brasero sending progress value = -1 in the initial stage of burning. The value of -1 is used internally by Brasero to indicate preparation stage or failure when burning; it's just passed "as is" to unity_launcher_ entry_set_ progress function.
We can fix the call to unity_launcher_ entry_set_ progress in Brasero to never pass -1. We could also add bounds check in unity2d - libunity-2d-private Application: :updateOverlays State method. But I think it's best to add bounds check (0.0 ... 1.0) in progress setter in libunity.