Ubuntu One Control Panel

The bin/ scripts should have no logic in them

Bug #910834 reported by Roberto Alsina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Confirmed
Undecided
Ubuntu One Client Engineering team
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Ubuntu One Control Panel 2.99.90
Trunk
Fix Released
Undecided
Roberto Alsina
Ubuntu One Windows Installer
Confirmed
Undecided
Ubuntu One Client Engineering team
Ubuntu Single Sign On Client
Confirmed
Undecided
Ubuntu One Client Engineering team
ubuntuone-control-panel (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

We should make those scripts trivial and move all the logic into the package.

Rationale:

* It would make it possible to write tests for that logic
* It removes the need to re-sign .exe files on each windows release, since they will be the same

Tags: u1-windows

Related branches

lp://staging/~ralsina/ubuntuone-control-panel/opt-parsing
Natalia Bidart (community): Approve
dobey (community): Approve
Diego Sarmentero (community): Approve
Diff: 269 lines (+161/-36)
6 files modified
bin/ubuntuone-control-panel-qt (+1/-30)
run-tests (+1/-1)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+36/-4)
ubuntuone/controlpanel/gui/qt/main/tests/__init__.py (+17/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+105/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/linux.py (+1/-1)
lp://staging/~nataliabidart/ubuntuone-control-panel/stable-3-0-update-2.99.90
Roberto Alsina (community): Approve
Diff: 11249 lines (+1476/-8283)
75 files modified
bin/ubuntuone-control-panel-gtk (+0/-54)
bin/ubuntuone-control-panel-qt (+8/-37)
com.ubuntuone.controlpanel.gui.service.in (+0/-3)
data/gtk/dashboard.ui (+0/-198)
data/gtk/device.ui (+0/-279)
data/gtk/devices.ui (+0/-44)
data/gtk/install.ui (+0/-57)
data/gtk/management.ui (+0/-334)
data/gtk/overview.ui (+0/-308)
data/gtk/services.ui (+0/-317)
data/gtk/volumes.ui (+0/-98)
data/qt/account.ui (+11/-5)
data/qt/controlpanel.ui (+14/-11)
data/qt/device.ui (+2/-2)
data/qt/device_remote.ui (+1/-1)
data/qt/devices.ui (+7/-4)
data/qt/folders.ui (+16/-13)
data/qt/images.qrc (+16/-11)
data/qt/loadingoverlay.ui (+1/-4)
data/qt/mainwindow.ui (+2/-2)
data/qt/preferences.ui (+22/-19)
data/qt/side_widget.ui (+214/-0)
data/qt/signin.ui (+115/-155)
data/qt/ubuntuone.qss (+48/-33)
docs/ubuntuone-control-panel-gtk.1 (+0/-15)
docs/ubuntuone-control-panel-qt.1 (+27/-0)
po/POTFILES.in (+0/-8)
run-tests (+3/-8)
run-tests.bat (+1/-1)
setup.py (+3/-40)
ubuntuone/controlpanel/backend.py (+17/-4)
ubuntuone/controlpanel/dbustests/test_gui_service.py (+0/-104)
ubuntuone/controlpanel/gui/__init__.py (+57/-10)
ubuntuone/controlpanel/gui/gtk/__init__.py (+0/-28)
ubuntuone/controlpanel/gui/gtk/gui.py (+0/-1667)
ubuntuone/controlpanel/gui/gtk/package_manager.py (+0/-62)
ubuntuone/controlpanel/gui/gtk/tests/__init__.py (+0/-232)
ubuntuone/controlpanel/gui/gtk/tests/test_gui.py (+0/-2179)
ubuntuone/controlpanel/gui/gtk/tests/test_gui_basic.py (+0/-780)
ubuntuone/controlpanel/gui/gtk/tests/test_package_manager.py (+0/-181)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+0/-205)
ubuntuone/controlpanel/gui/gtk/widgets.py (+0/-362)
ubuntuone/controlpanel/gui/qt/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/account.py (+9/-1)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+41/-7)
ubuntuone/controlpanel/gui/qt/device.py (+11/-1)
ubuntuone/controlpanel/gui/qt/devices.py (+9/-1)
ubuntuone/controlpanel/gui/qt/filesyncstatus.py (+3/-13)
ubuntuone/controlpanel/gui/qt/folders.py (+18/-5)
ubuntuone/controlpanel/gui/qt/gui.py (+5/-1)
ubuntuone/controlpanel/gui/qt/loadingoverlay.py (+7/-0)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+36/-4)
ubuntuone/controlpanel/gui/qt/main/tests/__init__.py (+17/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+105/-0)
ubuntuone/controlpanel/gui/qt/main/windows.py (+0/-3)
ubuntuone/controlpanel/gui/qt/preferences.py (+33/-1)
ubuntuone/controlpanel/gui/qt/side_widget.py (+81/-0)
ubuntuone/controlpanel/gui/qt/signin.py (+8/-59)
ubuntuone/controlpanel/gui/qt/systray.py (+8/-4)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+24/-71)
ubuntuone/controlpanel/gui/qt/tests/test_account.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+0/-2)
ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+19/-20)
ubuntuone/controlpanel/gui/qt/tests/test_devices.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_filesyncstatus.py (+13/-26)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+16/-3)
ubuntuone/controlpanel/gui/qt/tests/test_gui.py (+11/-1)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+2/-16)
ubuntuone/controlpanel/gui/qt/tests/test_side_widget.py (+90/-0)
ubuntuone/controlpanel/gui/qt/tests/test_signin.py (+39/-147)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+158/-0)
ubuntuone/controlpanel/gui/qt/ui/__init__.py (+1/-3)
ubuntuone/controlpanel/gui/qt/wizard.py (+110/-0)
ubuntuone/controlpanel/gui/tests/__init__.py (+14/-7)
ubuntuone/controlpanel/tests/test_web_client.py (+1/-1)
lp://staging/ubuntu/precise/ubuntuone-control-panel
Rick McBride (rmcbride)
Changed in ubuntuone-client:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntuone-control-panel:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntuone-windows-installer:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntu-sso-client:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntuone-client:
status: New → Confirmed
Changed in ubuntuone-control-panel:
status: New → Confirmed
Changed in ubuntuone-windows-installer:
status: New → Confirmed
Changed in ubuntu-sso-client:
status: New → Confirmed
Roberto Alsina (ralsina)
Changed in ubuntuone-control-panel:
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 2.99.90-0ubuntu1

---------------
ubuntuone-control-panel (2.99.90-0ubuntu1) precise; urgency=low

  * New upstream release:
    [ Natalia B. Bidart <email address hidden> ]
      - Changed the initial signin page so both login and register options
        are shown, and when clicked, the user is presented with either the Qt
        login dialog, or the Qt registration dialog (LP: #933576).
      - 'Apply these settings' button should be at the bottom right corner
        in the Settings tab (LP: #944120).
      - No more strings coming up from the Designer ui files (LP: #938626).
      - Make gettext return unicode so we can format strings
        with unicode variables (LP: #937809).
    [ Roberto Alsina <email address hidden> ]
      - Added a barebones manpage for ubuntuone-control-panel-qt
        (LP: #933021).
      - Preserved the scrollbar position when clearing/filling the folder
        list (LP: #942355).
      - Added keyboard shortcuts for quitting the control panel
        (LP: #900753).
      - Cleanup the ubuntuone-control-panel-qt script moving all logic into
        the main module (LP: #938102).
      - Parse Qt options correctly (LP: #910834).
      - Migrated to argparse when parsin command line options.
    [ Rodney Dawes <email address hidden> ]
      - Remove the GTK+ 2.x control panel (LP: #934270).
      - Pass ubuntuone-installer as app name to QApplication to avoid
        duplication (LP: #939691).
  * debian/control:
    - Bumped dependencies on ubuntu-sso-client to 2.99.90, on
      ubuntuone-client to 2.99.90, and on ubuntuone-installer to 2.99.90.
    - Converted ubuntuone-control-panel-gtk into a transitional package that
      depends on ubuntuone-control-panel-qt.
    - Made ubuntuone-control-panel suggests ubuntuone-control-panel-gui
      instead of recommending it, to avid seeding the Qt control panel to the
      default install.
    - Updated Standards-Version to 3.9.3.
  * debian/ubuntuone-control-panel-qt.install:
    - Install the new manpage provided by upstream.
  * debian/patches/fix-948970.patch:
    - Apply patch from upstream to have the new manpage being detected by
      disutils-extra and thus it gets installed in the expected location
      (LP: #948970).
  * debian/watch:
    - Updated to fetch latest milestone.
  * Removed debian/ubuntuone-control-panel-gtk.install since
    ubuntuone-control-panel-gtk is now a transitional package.
  * Removed patches which were included upstream.
 -- Natalia Bidart (nessita) <email address hidden> Wed, 07 Mar 2012 17:37:47 -0300

Changed in ubuntuone-control-panel (Ubuntu Precise):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.