Ubuntu Single Sign On Client

QT UI: strings in generated _ui.py are no longer marked for translation

Bug #938626 reported by Natalia Bidart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Ubuntu One Control Panel 2.99.90
Trunk
Fix Released
High
Natalia Bidart
Ubuntu Single Sign On Client
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Ubuntu Single Sign On Client 2.99.90
Trunk
Fix Released
High
Natalia Bidart
Ubuntu Translations
Fix Released
High
Unassigned
ubuntu-sso-client (Ubuntu)
Fix Released
Undecided
Unassigned
Ubuntu ubuntu-12.04-beta-1
ubuntuone-control-panel (Ubuntu)
Fix Released
Undecided
Unassigned
Ubuntu ubuntu-12.04-beta-1

Bug Description

Given that we're now installing the gettext translation with gettext.install (so we can use the flag unicode=True), we need to set all the strings programatically, instead of setting some from the Qt4 designer generated files.

Related branches

lp://staging/~nataliabidart/ubuntuone-control-panel/all-ui-from-code
Roberto Alsina (community): Approve
Manuel de la Peña (community): Approve
Diff: 989 lines (+243/-88)
22 files modified
data/qt/account.ui (+5/-5)
data/qt/controlpanel.ui (+7/-7)
data/qt/device.ui (+2/-2)
data/qt/device_remote.ui (+1/-1)
data/qt/devices.ui (+4/-4)
data/qt/folders.ui (+13/-13)
data/qt/loadingoverlay.ui (+1/-4)
data/qt/mainwindow.ui (+1/-1)
data/qt/preferences.ui (+13/-13)
data/qt/signin.ui (+7/-10)
ubuntuone/controlpanel/gui/__init__.py (+53/-7)
ubuntuone/controlpanel/gui/qt/account.py (+9/-1)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+25/-2)
ubuntuone/controlpanel/gui/qt/device.py (+11/-1)
ubuntuone/controlpanel/gui/qt/devices.py (+9/-1)
ubuntuone/controlpanel/gui/qt/folders.py (+13/-5)
ubuntuone/controlpanel/gui/qt/loadingoverlay.py (+7/-0)
ubuntuone/controlpanel/gui/qt/preferences.py (+33/-1)
ubuntuone/controlpanel/gui/qt/signin.py (+17/-3)
ubuntuone/controlpanel/gui/qt/systray.py (+7/-2)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+4/-2)
ubuntuone/controlpanel/gui/qt/ui/__init__.py (+1/-3)
lp://staging/~nataliabidart/ubuntu-sso-client/all-ui-from-code
Manuel de la Peña (community): Approve
Roberto Alsina (community): Approve
Diff: 4246 lines (+1955/-1959)
18 files modified
data/qt/choose_sign_in.ui (+163/-165)
data/qt/current_user_sign_in.ui (+181/-184)
data/qt/email_verification.ui (+113/-116)
data/qt/error_message.ui (+28/-31)
data/qt/forgotten_password.ui (+185/-188)
data/qt/loadingoverlay.ui (+3/-6)
data/qt/network_detection.ui (+139/-142)
data/qt/proxy_credentials_dialog.ui (+12/-15)
data/qt/reset_password.ui (+354/-357)
data/qt/setup_account.ui (+697/-700)
data/qt/success_message.ui (+32/-35)
ubuntu_sso/qt/email_verification_page.py (+4/-0)
ubuntu_sso/qt/loadingoverlay.py (+3/-0)
ubuntu_sso/qt/network_detection_page.py (+5/-1)
ubuntu_sso/qt/proxy_dialog.py (+1/-1)
ubuntu_sso/qt/setup_account_page.py (+14/-6)
ubuntu_sso/qt/tests/test_network_detection.py (+3/-1)
ubuntu_sso/utils/ui.py (+18/-11)
lp://staging/ubuntu/precise/ubuntu-sso-client
lp://staging/ubuntu/precise/ubuntuone-control-panel
lp://staging/~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.90
Roberto Alsina (community): Approve
Diff: 9631 lines (+3846/-3620)
64 files modified
bin/ubuntu-sso-proxy-creds-qt (+0/-4)
bin/ubuntu-sso-ssl-certificate-qt (+25/-0)
data/qt/choose_sign_in.ui (+0/-165)
data/qt/current_user_sign_in.ui (+163/-184)
data/qt/email_verification.ui (+105/-116)
data/qt/error_message.ui (+28/-31)
data/qt/forgotten_password.ui (+111/-188)
data/qt/loadingoverlay.ui (+3/-6)
data/qt/network_detection.ui (+139/-142)
data/qt/proxy_credentials_dialog.ui (+12/-15)
data/qt/reset_password.ui (+348/-357)
data/qt/setup_account.ui (+661/-700)
data/qt/ssl_dialog.ui (+205/-0)
data/qt/stylesheet.qss (+22/-30)
data/qt/success_message.ui (+32/-35)
run-tests.bat (+1/-1)
setup.py (+1/-0)
ubuntu_sso/credentials.py (+7/-0)
ubuntu_sso/main/glib.py (+4/-2)
ubuntu_sso/main/qt.py (+5/-3)
ubuntu_sso/networkstate/linux.py (+3/-1)
ubuntu_sso/networkstate/tests/test_linux.py (+3/-3)
ubuntu_sso/qt/__init__.py (+5/-0)
ubuntu_sso/qt/arrow.py (+68/-0)
ubuntu_sso/qt/current_user_sign_in_page.py (+32/-49)
ubuntu_sso/qt/email_verification_page.py (+39/-39)
ubuntu_sso/qt/enhanced_check_box.py (+1/-1)
ubuntu_sso/qt/error_page.py (+11/-4)
ubuntu_sso/qt/expander.py (+115/-0)
ubuntu_sso/qt/forgotten_password_page.py (+43/-113)
ubuntu_sso/qt/loadingoverlay.py (+7/-11)
ubuntu_sso/qt/main.py (+5/-0)
ubuntu_sso/qt/network_detection_page.py (+20/-9)
ubuntu_sso/qt/proxy_dialog.py (+6/-6)
ubuntu_sso/qt/reset_password_page.py (+31/-52)
ubuntu_sso/qt/setup_account_page.py (+95/-106)
ubuntu_sso/qt/sign_in_page.py (+0/-97)
ubuntu_sso/qt/ssl_dialog.py (+161/-0)
ubuntu_sso/qt/sso_wizard_page.py (+111/-33)
ubuntu_sso/qt/success_page.py (+13/-4)
ubuntu_sso/qt/tests/__init__.py (+160/-45)
ubuntu_sso/qt/tests/test_arrow.py (+90/-0)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+53/-143)
ubuntu_sso/qt/tests/test_email_verification.py (+34/-90)
ubuntu_sso/qt/tests/test_enchanced_line_edit.py (+2/-5)
ubuntu_sso/qt/tests/test_error_page.py (+26/-0)
ubuntu_sso/qt/tests/test_expander.py (+119/-0)
ubuntu_sso/qt/tests/test_forgotten_password.py (+38/-181)
ubuntu_sso/qt/tests/test_loadingoverlay.py (+8/-8)
ubuntu_sso/qt/tests/test_network_detection.py (+14/-34)
ubuntu_sso/qt/tests/test_reset_password.py (+25/-52)
ubuntu_sso/qt/tests/test_setup_account.py (+55/-105)
ubuntu_sso/qt/tests/test_sign_in_page.py (+0/-69)
ubuntu_sso/qt/tests/test_ssl_dialog.py (+199/-0)
ubuntu_sso/qt/tests/test_sso_wizard_page.py (+61/-97)
ubuntu_sso/qt/tests/test_success_page.py (+26/-0)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+91/-37)
ubuntu_sso/qt/ubuntu_sso_wizard.py (+95/-191)
ubuntu_sso/tests/test_credentials.py (+35/-6)
ubuntu_sso/utils/runner/__init__.py (+7/-9)
ubuntu_sso/utils/runner/tests/test_glib.py (+0/-1)
ubuntu_sso/utils/runner/tests/test_qt.py (+0/-1)
ubuntu_sso/utils/runner/tests/test_runner.py (+3/-2)
ubuntu_sso/utils/ui.py (+64/-37)
Ubuntu One hackers: Pending requested
Diff: 12 lines (+1/-1)
1 file modified
setup.py (+1/-1)
lp://staging/~nataliabidart/ubuntuone-control-panel/stable-3-0-update-2.99.90
Roberto Alsina (community): Approve
Diff: 11249 lines (+1476/-8283)
75 files modified
bin/ubuntuone-control-panel-gtk (+0/-54)
bin/ubuntuone-control-panel-qt (+8/-37)
com.ubuntuone.controlpanel.gui.service.in (+0/-3)
data/gtk/dashboard.ui (+0/-198)
data/gtk/device.ui (+0/-279)
data/gtk/devices.ui (+0/-44)
data/gtk/install.ui (+0/-57)
data/gtk/management.ui (+0/-334)
data/gtk/overview.ui (+0/-308)
data/gtk/services.ui (+0/-317)
data/gtk/volumes.ui (+0/-98)
data/qt/account.ui (+11/-5)
data/qt/controlpanel.ui (+14/-11)
data/qt/device.ui (+2/-2)
data/qt/device_remote.ui (+1/-1)
data/qt/devices.ui (+7/-4)
data/qt/folders.ui (+16/-13)
data/qt/images.qrc (+16/-11)
data/qt/loadingoverlay.ui (+1/-4)
data/qt/mainwindow.ui (+2/-2)
data/qt/preferences.ui (+22/-19)
data/qt/side_widget.ui (+214/-0)
data/qt/signin.ui (+115/-155)
data/qt/ubuntuone.qss (+48/-33)
docs/ubuntuone-control-panel-gtk.1 (+0/-15)
docs/ubuntuone-control-panel-qt.1 (+27/-0)
po/POTFILES.in (+0/-8)
run-tests (+3/-8)
run-tests.bat (+1/-1)
setup.py (+3/-40)
ubuntuone/controlpanel/backend.py (+17/-4)
ubuntuone/controlpanel/dbustests/test_gui_service.py (+0/-104)
ubuntuone/controlpanel/gui/__init__.py (+57/-10)
ubuntuone/controlpanel/gui/gtk/__init__.py (+0/-28)
ubuntuone/controlpanel/gui/gtk/gui.py (+0/-1667)
ubuntuone/controlpanel/gui/gtk/package_manager.py (+0/-62)
ubuntuone/controlpanel/gui/gtk/tests/__init__.py (+0/-232)
ubuntuone/controlpanel/gui/gtk/tests/test_gui.py (+0/-2179)
ubuntuone/controlpanel/gui/gtk/tests/test_gui_basic.py (+0/-780)
ubuntuone/controlpanel/gui/gtk/tests/test_package_manager.py (+0/-181)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+0/-205)
ubuntuone/controlpanel/gui/gtk/widgets.py (+0/-362)
ubuntuone/controlpanel/gui/qt/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/account.py (+9/-1)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+41/-7)
ubuntuone/controlpanel/gui/qt/device.py (+11/-1)
ubuntuone/controlpanel/gui/qt/devices.py (+9/-1)
ubuntuone/controlpanel/gui/qt/filesyncstatus.py (+3/-13)
ubuntuone/controlpanel/gui/qt/folders.py (+18/-5)
ubuntuone/controlpanel/gui/qt/gui.py (+5/-1)
ubuntuone/controlpanel/gui/qt/loadingoverlay.py (+7/-0)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+36/-4)
ubuntuone/controlpanel/gui/qt/main/tests/__init__.py (+17/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+105/-0)
ubuntuone/controlpanel/gui/qt/main/windows.py (+0/-3)
ubuntuone/controlpanel/gui/qt/preferences.py (+33/-1)
ubuntuone/controlpanel/gui/qt/side_widget.py (+81/-0)
ubuntuone/controlpanel/gui/qt/signin.py (+8/-59)
ubuntuone/controlpanel/gui/qt/systray.py (+8/-4)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+24/-71)
ubuntuone/controlpanel/gui/qt/tests/test_account.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+0/-2)
ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+19/-20)
ubuntuone/controlpanel/gui/qt/tests/test_devices.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_filesyncstatus.py (+13/-26)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+16/-3)
ubuntuone/controlpanel/gui/qt/tests/test_gui.py (+11/-1)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+2/-16)
ubuntuone/controlpanel/gui/qt/tests/test_side_widget.py (+90/-0)
ubuntuone/controlpanel/gui/qt/tests/test_signin.py (+39/-147)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+158/-0)
ubuntuone/controlpanel/gui/qt/ui/__init__.py (+1/-3)
ubuntuone/controlpanel/gui/qt/wizard.py (+110/-0)
ubuntuone/controlpanel/gui/tests/__init__.py (+14/-7)
ubuntuone/controlpanel/tests/test_web_client.py (+1/-1)
Natalia Bidart (nataliabidart)
Changed in ubuntuone-control-panel (Ubuntu):
milestone: none → ubuntu-12.04-beta-1
Changed in ubuntu-sso-client (Ubuntu):
milestone: none → ubuntu-12.04-beta-1
Changed in ubuntuone-control-panel:
assignee: nobody → Natalia Bidart (nataliabidart)
importance: Undecided → High
status: New → Fix Committed
Natalia Bidart (nataliabidart)
Changed in ubuntu-sso-client:
assignee: nobody → Natalia Bidart (nataliabidart)
importance: Undecided → High
status: New → In Progress
Gabor Kelemen (kelemeng)
Changed in ubuntu-translations:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-sso-client - 2.99.5-0ubuntu1

---------------
ubuntu-sso-client (2.99.5-0ubuntu1) precise; urgency=low

  * New upstream release:
    - Captcha loading is no longer failing for the Qt UI (LP: #933679).
    - Added stylesheets for the Qt UI.
    - Fixed: Qt UI: must call the backend passing reply_handler
      and error_handler (LP: #931452).
    - Make gettext return unicode strings. Also, transform arguments passed
      to the GLib spawnner to bytes (LP: #933632).
    - Try to load the qt main/ implementation when possible, if not default
      to the glib (LP: #933534).
    - Make the bin_dir discoverable when running from the system installation
      (LP: #933039).
    - Implement (so far dummy) timeout_func for the Qt frontend (LP: #933758).
  * debian/control:
    - adding missing dependency on gnome-keyring for python-ubuntu-sso-client
      (LP: #938693).
  * debian/patches/fix-938626.patch:
    - No more strings coming up from the Designer ui files so we ensure that
      those are marked for translation (LP: #938626).
  * debian/watch: updated milestone to 2.99.5.
 -- Natalia Bidart (nessita) <email address hidden> Wed, 22 Feb 2012 16:53:51 -0300

Changed in ubuntu-sso-client (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 2.99.5-0ubuntu1

---------------
ubuntuone-control-panel (2.99.5-0ubuntu1) precise; urgency=low

  * New upstream release:
    - Control Panel shows quota in red with more accuracy depending on the
      free space (LP: #901314).
    - The Qt UI will make the file sync button inactive while a (re-) connection
      is in progress (LP: #878867).
    - Center the Qt UI main window when openning it (LP: #934173).
  * debian/control:
    - added a new binary package ubuntuone-control-panel-common providing
      common files and images for the frontend packages.
    - ubuntuone-control-panel-qt and ubuntuone-control-panel-gtk now depend on
      ubuntuone-control-panel-common.
    - bumping dependencies on ubuntu-sso-client to 2.99.5 and on
      ubuntuone-client to 2.99.4.
  * debian/patches/fix-937809-938626.patch:
    - Make gettext return unicode so we can format strings with unicode
      variables (LP: #937809).
    - No more strings coming up from the Designer ui files to ensure those get
      listed for translation (LP: #938626).
  * debian/ubuntuone-control-panel-common.install: new binary package listing
    files used by both the Qt and the GTK+ UIs.
  * debian/watch: updated milestone to 2.99.5.
 -- Natalia Bidart (nessita) <email address hidden> Wed, 22 Feb 2012 17:29:31 -0300

Changed in ubuntuone-control-panel (Ubuntu):
status: New → Fix Released
Gabor Kelemen (kelemeng)
Changed in ubuntu-translations:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.