$(SHELL) config.status broken

Please provide a tarball containing the problem package, and instructions to replicate.

Clearly you're the only person seeing this, and so it must be something about the program you're using.

I just reproduced in a clean new jaunty up-to-date vm.

sudo apt-get install subversion
svn co svn://svn.gnome.org/svn/gtk+/trunk gtk+ && cd gtk+
sudo apt-get install --without-recommends build-essential libtool gtk-doc-tools autoconf automake1.7 libglib2.0-dev libatk1.0-dev libpango1.0-dev libcairo2-dev
# --help is to disable the configure run
./autogen --help
mkdir build && cd build
../configure --without-libtiff --without-libjasper
make

This fails with:
...
/usr/bin/ld:.libs/libgdk_pixbuf-2.0.ver:2: ignoring invalid character `\001' in script
/usr/bin/ld:.libs/libgdk_pixbuf-2.0.ver:2: syntax error in VERSION script
and indeed the build/ libtool as odd characters in it. Note that the libtool script is fine after "configure" and is also fine if one reruns config.status.

This is regular jaunty so /bin/sh is dash and the above is run under bash.

Bye,

On Fri, 2009-02-27 at 11:10 +0000, Loïc Minier wrote:

> ./autogen --help
>
What happens if you use "autoreconf -i" instead of autogen.sh ?

(You may need to run gtkdocize by hand first)

Scott
--
Scott James Remnant
<email address hidden>

Same error with gtkdocize + autoreconf.

I could reproduce with gtk+-2.14.4 from intrepid (just the .orig tarball) with "autoreconf -fi" followed by configure and make (as previously described).

This is a bug in the gtk+2.0 source package, specifically the po-properties sub-directory.

The Makefile there recalls config.status (probably wrongly), but has the SHELL variable hardcoded to /bin/sh

At the very least, the original Makefile.in.in needs to have SHELL = @SHELL@, which will pass on to the Makefile.in and then have SHELL replaced with the correct local value.

I'd strongly suggest someone review the mess though ;-)

Scott, I understand that the SHELL usage is incorrect, I even outlined it in my report, but it's duplicated in many tarballs as it's present in gettext's and intltool's Makefile.in.in, so we need to revert the change which exposes this bug first.

19:28 < lool> Keybuk: Ah
19:28 < lool> Keybuk: after configure, po-properties doesn't have a POTFILES
              while po has!
19:28 < Keybuk> lool: ah!
19:28 < Keybuk> lool: that's probably a bug ;)
19:28 < Keybuk> I've just tested here btw, general gettext fails here too
19:28 < Keybuk> but it's quite hard to replicate
19:28 -!- sabdfl [n=sabdfl@ubuntu/member/sabdfl] has joined #ubuntu-devel
19:29 < Keybuk> ohhhhhhhhhhhhhhhh
19:29 < Keybuk> I've just realised why general gettext doesn't replicate this ;)
19:30 < Keybuk> gettext upstream only calls config.status with its own
                directory name
19:30 < Keybuk> so it only regenerates po/Makefile
19:30 < lool> Which is cleaner
19:30 < Keybuk> so it doesn't smash libtool
19:30 < lool> Keybuk: Ok, the po/POTFILES generation is in glib-gettext.m4, so
              it's specific to this implementation as well
19:30 < Keybuk> it's still a bug that SHELL is overwritten, but it minimises it
19:30 < lool> Keybuk: I think we have a bunch of bugs to fix here; thanks for
              debugging!

=> affects gettext (SHELL), intltool (SHELL), glib x 2 (SHELL and config.status usage), gtk+ (missing configure snippet like for po/), gnulib (SHELL) ...

I'm attaching the patch against SVN which I sent upstream and which fixes the build for me; it only fixes the gtk+/po-properties/-specific bug; the general use of config.status in Makefile.in.in is still poor, but I'll wait for gettext's folks take on this issue before patching these files.

Just FYI, intltool and glib-gettext lack it but upstream gettext has support for multiple po directories.

the new glib version in jaunty fixes the issue

the bug is fixed upstream now

the issue has been fixed upstream now

This bug was fixed in the package gettext - 0.17-6ubuntu2

---------------
gettext (0.17-6ubuntu2) jaunty; urgency=low

  * Cherry-pick df8857c0472c33bd786a967569c4b3c9c4c177b2 from upstream to use
    autoconf's preferred shell when invoking config.status; LP: #332840.

 -- Loic Minier <email address hidden> Tue, 03 Mar 2009 10:04:46 +0100

new gtk uploaded

the new version is in jaunty now

This was fixed in Gnulib a while back:

commit 681846cee55a407a08a2bbdc7e1484870ba1a79f
Author: Bruno Haible <email address hidden>
Date: Tue May 25 21:35:22 2010 +0200

    Update to GNU gettext 0.18, part 2.

This means it's also fixed in the gnulib package in natty (though not maverick, by the looks of things).

And, as implied by my last comment, it's fixed in gettext 0.18 too.

commit f12d1cd1d765dd7bf20986d3882884b561ee8820
Author: Bruno Haible <email address hidden>
Date: Fri Feb 27 20:07:34 2009 +0000

    Use autoconf's preferred shell when invoking config.status.