widelands

AppVeyor platform update 11/09/18

Bug #1803107 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

appveyor broken again. seems like the last windows image update removed the bcrypt libraries (as it is the case in win 10), so boost 1.67 is not working. so we can try to downgrade boost or to change the random generator.

Suspected culprit is: generate_random_uuid()

@Notabilis: Can we just use rand() instead?

Related branches

lp://staging/~widelands-dev/widelands/update_appveyor
Tino: Approve
Diff: 61 lines (+10/-5)
3 files modified
CMakeLists.txt (+1/-1)
appveyor.yml (+2/-2)
utils/win32/innosetup/Widelands.iss (+7/-2)
Revision history for this message
Tino (tino79) wrote :

=> https://github.com/boostorg/uuid/issues/68

Revision history for this message
Tino (tino79) wrote :

Appveyor Platform Update incl. MSYS2 https://github.com/appveyor/ci/issues/2703 on 11/09/18.
As far as i can see, there a several breaker:
- Static linking for boost does no longer work, because bcrypt does not get linked
- on x86_64 the glbindings seem to be broken
- dll renames (e.g. libfluidsynth)

Changed in widelands:
assignee: Notabilis (notabilis27) → Tino (tino79)
summary: - AppVeyor no longer supports bcrypt
+ AppVeyor platform update 11/09/18
Tino (tino79)
Changed in widelands:
status: New → In Progress
Revision history for this message
Notabilis (notabilis27) wrote :

If I understand Tino's branch and the problem correctly we will now manually request linking with bcrypt, so I think generate_random_uuid() can stay in (not tested).

If required, we could replace it with rand(), though I wouldn't like it. generate_random_uuid() is a cryptographic function so it creates "good" random values while the result of rand() shouldn't be used for security purposes. But, well, it probably doesn't really matters in our case anyway.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Just out of curiosity (and to understand how to update my Windows 10 building Environment):
What was the issue with glbinding? Couldn't see this in the logs.

Revision history for this message
Tino (tino79) wrote :

https://ci.appveyor.com/project/widelands-dev/widelands/builds/20263492/job/pub38qq5fhdlgtui

When I connected via RDP and started a test or widelands manually, i got a unknown entry point exception in libglbinding.dll.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Interesting thing is that the Version of Glbinding hasn't changed between the last green appveyor build and the first red one. Also boost version hasn't changed.
Changes in MSYS2 I could identify from the log were:

Sdl2 2.0.8  2.0.9
Fluidsynth 1.1.11  2.0.0
glib2 2.56.1  2.58.1
harfbuzz 1.8.8  2.1.0
opus 1.3 (not part of the chain previously)
opusfile 0.11 (not part of the chain previously)
sdl2mixer 2.0.2  2.0.4

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: Tino (tino79) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.