Invisible text in insenstitive suggested action buttons
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-themes (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Impact
------
The suggestion action button does not have correct text styling when the action button is "insensitive" (greyed out). This makes the text basically invisible since it has the same dark grey color for both the foreground text and the background.
Test Case 1
-----------
1. Open the file browser.
2. Open the ☰ menu and select New Folder.
What happens:
1. In the New Folder dialog, the top right button has invisible text. Screenshot attached.
What should happen:
It should show the word Create but greyed out.
Test Case 2
-----------
1. Open the gedit text editor.
2. Open the ☰ menu and select Save As.
3. In the Name field, delete all the text to make the field empty.
What happens:
The word Save in the top right button becomes invisible.
Regression Potential
-------
Color for elements other than the label of suggested actions is wrong
Other Info
----------
Ubuntu 18.04.1 LTS
light-themes 16.10+18.
Ambiance theme
libgtk-3-0 3.22.30-1ubuntu1
Related branches
- Andrea Azzarone (community): Approve
-
Diff: 368 lines (+154/-16)9 files modifiedAmbiance/gtk-3.20/apps/chromium.css (+4/-0)
Ambiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Ambiance/gtk-3.20/gtk-main.css (+1/-0)
Ambiance/gtk-3.20/gtk-widgets.css (+49/-6)
Radiance/gtk-3.20/apps/chromium.css (+4/-0)
Radiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-0)
Radiance/gtk-3.20/gtk-widgets.css (+51/-8)
debian/changelog (+24/-0)
- Ubuntu Artwork Packagers: Pending requested
-
Diff: 372 lines (+152/-17)9 files modifiedAmbiance/gtk-3.20/apps/chromium.css (+4/-0)
Ambiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Ambiance/gtk-3.20/gtk-main.css (+1/-0)
Ambiance/gtk-3.20/gtk-widgets.css (+49/-6)
Radiance/gtk-3.20/apps/chromium.css (+4/-0)
Radiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-1)
Radiance/gtk-3.20/gtk-widgets.css (+51/-8)
debian/changelog (+22/-0)
| Jeremy Bícha (jbicha) wrote | #1 |
| Changed in ubuntu-themes (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in ubuntu-themes (Ubuntu): | |
| status: | New → Confirmed |
| no longer affects: | ubuntu-themes |
| Changed in ubuntu-themes (Ubuntu): | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| status: | Confirmed → In Progress |
| description: | updated |
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu-themes (Ubuntu): | |
| status: | In Progress → Fix Released |
| Łukasz Zemczak (sil2100) wrote Please test proposed package | #3 |
| Changed in ubuntu-themes (Ubuntu Bionic): | |
| status: | New → Fix Committed |
| tags: | added: verification-needed verification-needed-bionic |
| Marco Trevisan (Treviño) (3v1n0) wrote | #4 |
| tags: |
added: verification-done verification-done-bionic removed: verification-needed verification-needed-bionic |
| Marco Trevisan (Treviño) (3v1n0) wrote | #5 |
| Launchpad Janitor (janitor) wrote | #6 |
| Changed in ubuntu-themes (Ubuntu Bionic): | |
| status: | Fix Committed → Fix Released |
| Chris Halse Rogers (raof) wrote Update Released | #7 |
This bug was fixed in the package ubuntu-themes - 16.10+18.
---------------
ubuntu-themes (16.10+
[ Khurshid Alam ]
* Remove nonexistent gnome-builder.css (LP: #1773045)
[ Marco Trevisan (Treviño) ]
* Radiance: fix typo in assets link for focused buttons (LP: #1781736)
* Radiance: Use scaled image for buttons border (LP: #1781736)
* Ambiance, Radiance: don't use padding on window buttons for chromium
(LP: #1782038)
* Ambiance: use default foreground color for toolbar menus (LP:
#1758841)
* Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
* Ambiance, Radiance: use default disabled color for actions headerbar
buttons (LP: #1785699)
* Ambiace, Radiance: use headerbar destructive-action definition for
buttons
* Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
#1761684)
* Ambiance, Radiance: properly theme disabled and hovered accelerators
(LP: #1795895)
-- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:13:07 +0000