Ubuntu
ubuntu-themes package

Window buttons are small in a maximized Chromium window

Bug #1782038 reported by Thomas Anderson on 2018-07-16

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	ubuntu-themes (Ubuntu)	Fix Released	Medium	Marco Trevisan (Treviño)
	Bionic	Fix Released	Undecided	Unassigned

Bug Description

[ Impact ]

In maximized google-chrome / chromium window buttons for close, minimize, and restore buttons should be normal-sized, but instead appear small.

[ Test case ]

1. Use the Ambiance or Radiance themes.
2. Launch a Chromium or Google Chrome window.
3. Ensure that in chrome settings, the "Use system borders" option is unchecked
4. Maximize.
5. Window buttons should have normal size.

[ Regression potential ]

Other windows buttons could loose the padding used for being closed.

---

Repro:
1. Use the Ambiance or Radiance themes.
2. Launch a Chromium window.
3. Maximize.

The window close, minimize, and restore buttons should be normal-sized, but instead appear small.

This is because the buttons have a padding of 9px on the top and bottom, causing Chromium to think they're taller than they really are, so it downsizes them to fit the smaller headerbar on the maximized window.

The attached patch removes the padding. There are no changes in behavior in apps other than Chromium.

See original description

Tags:

Related branches

lp://staging/~3v1n0/ubuntu-themes/cosmic-fixes

Merged into lp://staging/ubuntu-themes at revision 627

Andrea Azzarone (community): Approve on 2018-10-05

lp://staging/~3v1n0/ubuntu-themes/bionic-sru1

Merged into lp://staging/ubuntu-themes/bionic at revision 626

Ubuntu Artwork Packagers: Pending requested 2018-10-03

lp://staging/~ci-train-bot/ubuntu-themes/ubuntu-themes-ubuntu-bionic-3453

lp://staging/~ci-train-bot/ubuntu-themes/ubuntu-themes-ubuntu-cosmic-3452

Revision history for this message

Thomas Anderson (thomas.anderson) wrote on 2018-07-16:

patch.diff Edit (808 bytes, text/plain)

Daniel van Vugt (vanvugt) on 2018-07-17

tags:

added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2018-07-25:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-themes (Ubuntu):
status:	New → Confirmed

Revision history for this message

Ínitu Castilhos da Rosa (initu-icr) wrote on 2018-07-25:

Screenshot_2018-07-25-17-21-09.png Edit (171.2 KiB, image/png)

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2018-07-26:

The attachment "patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Marco Trevisan (Treviño) (3v1n0) on 2018-10-02

no longer affects:	ubuntu-themes
Changed in ubuntu-themes (Ubuntu):
status:	Confirmed → In Progress
importance:	Undecided → Medium
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2018-10-03:

Thanks for the patch, that was fine for chrome, but it broke the activation area for other apps, so I've reduced the selector to only chrom{e,ium} buttons.

summary:

- [Patch included] Window buttons are small in a maximized Chromium window
+ Window buttons are small in a maximized Chromium window

Marco Trevisan (Treviño) (3v1n0) on 2018-10-04

description:

updated

Revision history for this message

Launchpad Janitor (janitor) wrote on 2018-10-08:

This bug was fixed in the package ubuntu-themes - 16.10+18.10.20181005-0ubuntu1

---------------
ubuntu-themes (16.10+18.10.20181005-0ubuntu1) cosmic; urgency=medium

[ Khurshid Alam ]
* Remove nonexistent gnome-builder.css (LP: #1773045)

  [ Marco Trevisan (Treviño) ]
  * Radiance: fix typo in assets link for focused buttons (LP: #1781736)
  * Radiance: Use scaled image for buttons border (LP: #1781736)
  * Ambiance, Radiance: don't use padding on window buttons for chromium
    (LP: #1782038)
  * Ambiance: use default foreground color for toolbar menus (LP:
    #1758841)
  * Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
  * Ambiance, Radiance: use default disabled color for actions headerbar
    buttons (LP: #1785699)
  * Ambiace, Radiance: use headerbar destructive-action definition for
    buttons
  * Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
    #1761684)
  * Ambiance, Radiance: properly theme disabled and hovered accelerators
    (LP: #1795895)

-- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:13:07 +0000

Changed in ubuntu-themes (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2018-10-08: Please test proposed package

Hello Thomas, or anyone else affected,

Accepted ubuntu-themes into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-themes/16.10+18.04.20181005-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-themes (Ubuntu Bionic):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-bionic

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2018-10-18:

$ apt-cache policy light-themes
light-themes:
Installato: 16.10+18.04.20181004-0ubuntu1
Candidato: 16.10+18.04.20181004-0ubuntu1

I confirm this is fixed in chrome and chromium. No regression on clicking area.

tags:

added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2018-10-22:

Same with:

marco@tricky:/tmp:✗ $ LC_ALL=C apt-cache policy light-themes
light-themes:
  Installed: 16.10+18.04.20181005-0ubuntu1
  Candidate: 16.10+18.04.20181005-0ubuntu1
  Version table:
*** 16.10+18.04.20181005-0ubuntu1 100

Revision history for this message

Launchpad Janitor (janitor) wrote on 2018-10-23:

#10

This bug was fixed in the package ubuntu-themes - 16.10+18.04.20181005-0ubuntu1

---------------
ubuntu-themes (16.10+18.04.20181005-0ubuntu1) bionic; urgency=medium

[ Khurshid Alam ]
* Remove nonexistent gnome-builder.css (LP: #1773045)

  [ Marco Trevisan (Treviño) ]
  * Radiance: fix typo in assets link for focused buttons (LP: #1781736)
  * Radiance: Use scaled image for buttons border (LP: #1781736)
  * Ambiance, Radiance: don't use padding on window buttons for chromium
    (LP: #1782038)
  * Ambiance: use default foreground color for toolbar menus (LP:
    #1758841)
  * Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
  * Ambiance, Radiance: use default disabled color for actions headerbar
    buttons (LP: #1785699)
  * Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
    #1761684)
  * Ambiance, Radiance: properly theme disabled and hovered accelerators
    (LP: #1795895)

-- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:08:30 +0000

Changed in ubuntu-themes (Ubuntu Bionic):
status:	Fix Committed → Fix Released

Revision history for this message

Chris Halse Rogers (raof) wrote on 2018-10-23: Update Released

#11

The verification of the Stable Release Update for ubuntu-themes has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.