Snapcraft

test_cleanbuild unit test fails when executed in a platform that's not amd64

Bug #1589747 reported by Leo Arias
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Medium
Leo Arias
Snapcraft 2.11
snapcraft (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Ubuntu xenial-updates
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

The unittest has the expected architecture value hardcoded to amd64, so when it is run in a different architecture it will fail.

FAIL: test_cleanbuild (snapcraft.tests.test_lxd.LXDTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
    return func(*args, **keywargs)
  File "/tmp/autopkgtest.v8hLiN/build.kH3/snapcraft-2.9/snapcraft/tests/test_lxd.py", line 76, in test_cleanbuild
    call(['lxc', 'remote', 'remove', 'my-pet'])])
  File "/usr/lib/python3.5/unittest/mock.py", line 824, in assert_has_calls
    ) from cause
AssertionError: Calls not found.
Expected: [call(['lxc', 'remote', 'add', 'my-pet', 'https://images.linuxcontainers.org:8443']), call(['lxc', 'launch', 'my-pet:ubuntu/xenial/amd64', 'snapcraft-my-pet']), call(['lxc', 'file', 'push', 'project.tar', 'snapcraft-my-pet//root/project.tar']), call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'tar', 'xvf', '/root/project.tar']), call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'python3', '-c', 'import urllib.request; urllib.request.urlopen("http://start.ubuntu.com/connectivity-check.html", timeout=5)']), call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'apt-get', 'update']), call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'apt-get', 'install', 'snapcraft', '-y']), call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'snapcraft', 'snap', '--output', 'snap.snap']), call(['lxc', 'file', 'pull', 'snapcraft-my-pet//root/snap.snap', 'snap.snap']), call(['lxc', 'stop', 'snapcraft-my-pet']), call(['lxc', 'remote', 'remove', 'my-pet'])]
Actual: [call(['lxc', 'remote', 'add', 'my-pet', 'https://images.linuxcontainers.org:8443']),
 call(['lxc', 'launch', 'my-pet:ubuntu/xenial/i386', 'snapcraft-my-pet']),
 call(['lxc', 'file', 'push', 'project.tar', 'snapcraft-my-pet//root/project.tar']),
 call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'tar', 'xvf', '/root/project.tar']),
 call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'python3', '-c', 'import urllib.request; urllib.request.urlopen("http://start.ubuntu.com/connectivity-check.html", timeout=5)']),
 call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'apt-get', 'update']),
 call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'apt-get', 'install', 'snapcraft', '-y']),
 call(['lxc', 'exec', 'snapcraft-my-pet', '--', 'snapcraft', 'snap', '--output', 'snap.snap']),
 call(['lxc', 'file', 'pull', 'snapcraft-my-pet//root/snap.snap', 'snap.snap']),
 call(['lxc', 'stop', 'snapcraft-my-pet']),

[Impact]

 * No visible impact for users.

 * Fixing this test will get us closer to have green executions in autopkgtests in all the platforms.

[Test Case]

 * Run the autopkgtests in a platform that's not amd64,

[Regression Potential]

 * This could make fail the tests in amd64. But as it's in an autopkgtest, any regression will block the new version to get to proposed.

Leo Arias (elopio)
Changed in snapcraft:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Leo Arias (elopio)
milestone: none → 2.11
Revision history for this message
Leo Arias (elopio) wrote :

https://github.com/ubuntu-core/snapcraft/pull/552

Sergio Schvezov (sergiusens)
Changed in snapcraft:
milestone: 2.12 → 2.11
status: In Progress → Fix Committed
Changed in snapcraft (Ubuntu Xenial):
milestone: none → xenial-updates
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapcraft (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Leo Arias (elopio) wrote :

This bug doesn't affect users. I'm marking it as verification done.

We still have failures in other architectures, but this test is now passing. Other bugs are open to address the remaining issues.

Thanks Brian!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.11

---------------
snapcraft (2.11) xenial; urgency=medium

  [ Leo Arias ]
  * Make the lxd unit test pass in architectures other than amd64. (#552)
    (LP: #1589747)
  * Support running the snaps tests in multiple architectures (#554)
    (LP: #1589779)
  * Make the IsDirty unit test case pass in architectures other than
    amd64. (#553) (LP: #1589752)

  [ Didier Roche ]
  * Reenable get and set tourdir unit tests (#551) (LP: #1589782)
  * Add finale tour examples and tests (#558) (LP: #1590903)
  * Reenable tour command (#559) (LP: #1590906)

  [ Sergio Schvezov ]
  * Fix or address lintian errors and warnings (#561) (LP: #1588980)

 -- Sergio Schvezov <email address hidden> Thu, 09 Jun 2016 18:46:22 -0300

Changed in snapcraft (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Sergio Schvezov (sergiusens)
Changed in snapcraft:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.12+16.10

---------------
snapcraft (2.12+16.10) yakkety; urgency=medium

  [ Simon Quigley ]
  * Change apt-get to apt in HACKING.md (#564) (LP: #1591421)
  * Changed the mailing list in HACKING.md from snappy-devel to snapcraft
    (#577)
  * Add Subversion support (#567) (LP: #1543243)

  [ Joe Talbott ]
  * Include 'maintainer' and 'description' in the parser output. (#565)
    (LP: #1591199)
  * Support "```" wiki code tags in the parser. (#569) (LP: #1592133)
  * Add snapcraft-parser integration test. (#560) (LP: #1590268)
  * Make most wiki fields required. (#581) (LP: #LP: #1592133)
  * Add more info about reusable parts. (#527) (LP: #1582499)
  * Allow parts without a 'source' entry. (#599)

  [ Sergio Schvezov ]
  * New plugin: gulp (#563) (LP: #1575880)
  * Support for a hidden snapcraft.yaml (#582) (LP: #1587933)
  * Implement `snapcraft update` for parts (#588) (LP: #1594643)
  * Support updating cache without content-length (#598) (LP: #1595610)
  * Switch from local copy to the proper python package. (LP: #1590813)
  * Integrate with new remote parts (#590) (LP: #1594976)
  * Implement `snapcraft define` for parts (#594) (LP: #1594643)
  * Update the remote parts cache before demo tests (#604) (LP: #1596114)
  * Add missing build-packages for rpath test (#605) (LP: #1596114)
  * Implement snapcraft search (#608) (LP: #1596222)

  [ Bayard Randel ]
  * Ignore .eggs dir. (#572)

  [ Leo Arias ]
  * Use pexpect when testing the building of snaps (#573) (LP: #1592943)
  * Allow to run a subset of integration tests. (#576) (LP: #1593009)
  * Improve the store errors returning exceptions (#585) (LP: #1594636)
  * Add the register command (#586) (LP: #1595012)
  * Improve error reporting (#591) (LP: #1588023)
  * Fix the store update test to register a unique name (#595) (LP: #1595319)
  * Use a xenial docker container for travis executions (#597) (LP: #1532213)
  * Simplify the list plugins integration test (#607) (LP: #1596112)
  * Remove the unittests from the autopkgtest execution (#600) (LP: #1596068)

  [ Evan Dandrea ]
  * Make lxd containers ephemeral. (#578) (LP: #1577548)

  [ Daniel Holbach ]
  * it's myapps.developer.ubuntu.com (#587) (LP: #1594844)

  [ Rob Loach ]
  * Fix Snap icons for Demos (#574)

  [ Kyle Fazzari ]
  * Add qmake plugin. (#566) (LP: #1574774)
  * Don't copy libraries that are already in prime. (#580) (LP: #1570895)
  * Make app names more restrictive. (#555) (LP: #1589613)

 -- Sergio Schvezov <email address hidden> Mon, 27 Jun 2016 13:58:10 -0300

Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.