Snapcraft

get_unbound_discharge returns a tuple with (value, error)

Bug #1594636 reported by Leo Arias
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Medium
Leo Arias
Snapcraft 2.12
snapcraft (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Medium
Unassigned
Yakkety
Fix Released
Medium
Unassigned

Bug Description

In snapcraft/storeapi/__init__.py, the method get_unbound_discharge returns a tuple. The first element is the return value on success, the second is the error on failure.

That's not pythonic. The method should return the value or raise an exception.

[Impact]

 * For users, none.

 * For developers, the code is less clear because it's not following the common python practices.

[Test Case]

 * Run all the methods that access the store:
   login, upload, download.

[Regression Potential]

 * This could affect the commands that access the store.

Revision history for this message
Leo Arias (elopio) wrote :

Also get_macaroon in the same file returns a tuple.

Changed in snapcraft:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Leo Arias (elopio)
milestone: none → 2.12
Revision history for this message
Leo Arias (elopio) wrote :

https://github.com/ubuntu-core/snapcraft/pull/585

Sergio Schvezov (sergiusens)
Changed in snapcraft:
status: In Progress → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Leo Arias (elopio) wrote :

Tested in an up-to-date xenial:

- enabled -proposed
- update snapcraft-parser to 2.12
- ran exploratory on login, logout, upload, register.

I'm going to mark this as verified, thanks Steve!

tags: added: verification-done
removed: verification-needed
Sergio Schvezov (sergiusens)
Changed in snapcraft:
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Mathew Hodson (mhodson)
affects: Ubuntu Xenial → snapcraft (Ubuntu Xenial)
Changed in snapcraft (Ubuntu Xenial):
status: New → Fix Released
importance: Undecided → Medium
Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released
importance: Undecided → Medium
Sergio Schvezov (sergiusens)
Changed in snapcraft (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.