juju-core

Vivid unit tests need to pass

Bug #1433577 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Eric Snow
juju-core 1.24-alpha1
1.23
Fix Released
High
Eric Snow
juju-core 1.23-beta3

Bug Description

We have seen the vivid unit tests pass, but that id only 1/10. We need to get this suite reliable for 1.23.0. The common test failures are:
FAIL: pinger_test.go:97: pingerSuite.TestAgentConnectionDelaysShutdownWithPing
FAIL: root_test.go:40: rootSuite.TestPingTimeout
FAIL: replicaset_test.go:157: MongoSuite.TestAddRemoveSet (bug 1398415)
FAIL: tracker_test.go:406: TrackerSuite.TestWaitMinionNeverBecomeMinion (bug 1433384)

The pingerSuite.TestAgentConnectionDelaysShutdownWithPing and rootSuite.TestPingTimeout failures are odd. We commonly see these tests fail when the tests are run in lxc, but the vivid host is a 8G RAM 30G disk machine with 2 CPUs. Vivid uses go1.3.3

See original description
Revision history for this message
Curtis Hovey (sinzui) wrote :

Attached is a log of the run.

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

This appears to be related to https://bugs.launchpad.net/juju-core/+bug/1433384.

Martin Packman (gz)
description: updated
Eric Snow (ericsnowcurrently)
Changed in juju-core:
milestone: 1.23 → 1.24-alpha1
Revision history for this message
Martin Packman (gz) wrote :

Another test run:

<http://data.vapour.ws/juju-ci/products/version-2478/run-unit-tests-vivid-amd64/build-289/consoleText>

logs_test.go:109: LogsSuite.TestPruneLogsBySize
worker_test.go:89: suite.TestPrunesLogsBySize
worker_test.go:54: suite.TestPrunesOldLogs

(all bug 1434741 and fixed on trunk)

resumer_test.go:37: ResumerSuite.TestResumerCalls
resumer_test.go:61:
    c.Assert(diff <= 4*testInterval, jc.IsTrue)
... obtained bool = false

No current bug filed? Also intermittent?

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

I've addressed lp:1408459 but there are other failures that need to be addressed. I expect we will bump into various transient failures as time goes by, not unlike what happens with merge-gating and with the other unit tests. Regardless, I'm aiming to at least get the test runs consistently passing ASAP, and certainly for the 1.23.0 release.

Changed in juju-core:
assignee: nobody → Eric Snow (ericsnowcurrently)
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

I've opened lp:1436397 for one of the failures. Note that it does not affect 1.23 (only master).

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

I've opened lp:1436407 for the (currently) only remaining test failure on 1.23.

Eric Snow (ericsnowcurrently)
Changed in juju-core:
status: Triaged → In Progress
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

intermittent on 1.23: lp:1398415 (old bug)

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

a possibly intermittent failure on 1.23: lp:1436495 (new bug)

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

I'd meant to say *1.24* on that last one.

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

Another possibly intermittent failure on 1.24: lp:1436507 (new bug)

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

Both 1.23 and master are now passing intermittently. Presumably we still need to get them passing much more consistenly.

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

On master the tests should consistently pass once the proposed fix for lp:1436397 lands (probably today).

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

I've logged another intermittent one for master: lp:1438274.

Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

The tests are passing frequently enough that I'm closing this issue. An further specific failures can be addressed in new issues.

Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.