unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion

Bug #1433384 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
1.23
Fix Released
Critical
William Reade

Bug Description

The TrackerSuite.TestWaitMinionBecomeMinion is failing and is preventing utopic amd64 and precise i386 unit-tests from being blessed.

FAIL: tracker_test.go:369: TrackerSuite.TestWaitMinionBecomeMinion

tracker_test.go:375:
    // Check the first ticket stays open.
    assertWaitMinion(c, tracker, false)
tracker_test.go:468:
    c.Fatalf("got unexpected readiness: %v", ticket.Wait())
... Error: got unexpected readiness: true

OOPS: 12 passed, 1 FAILED
--- FAIL: TestPackage (0.56 seconds)

Revision history for this message
Curtis Hovey (sinzui) wrote :

This test is also the reason run-unit-tests-precise-i386 is failing.

tags: added: i386
description: updated
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

I can reproduce this with gccgo on amd64 as well:

----------------------------------------------------------------------
FAIL: tracker_test.go:369: com_juju_juju_worker_leadership_test.TestWaitMinionBecomeMinion.pN56_github.com_juju_juju_worker_leadership_test.TrackerSuite

tracker_test.go:468:
    c.Fatalf("got unexpected readiness: %v", ticket.Wait())
... Error: got unexpected readiness: true

----------------------------------------------------------------------
PASS: tracker_test.go:406: com_juju_juju_worker_leadership_test.TestWaitMinionNeverBecomeMinion.pN56_github.com_juju_juju_worker_leadership_test.TrackerSuite 0.126s
OOPS: 12 passed, 1 FAILED
--- FAIL: TestPackage (0.60 seconds)
FAIL
exit status 1
FAIL github.com/juju/juju/worker/leadership 1.308s

And even with gc/amd64:

----------------------------------------------------------------------
FAIL: tracker_test.go:369: TrackerSuite.TestWaitMinionBecomeMinion

tracker_test.go:375:
    // Check the first ticket stays open.
    assertWaitMinion(c, tracker, false)
tracker_test.go:468:
    c.Fatalf("got unexpected readiness: %v", ticket.Wait())
... Error: got unexpected readiness: true

----------------------------------------------------------------------
PASS: tracker_test.go:406: TrackerSuite.TestWaitMinionNeverBecomeMinion 0.125s
OOPS: 12 passed, 1 FAILED
--- FAIL: TestPackage (0.56 seconds)
FAIL
exit status 1
FAIL github.com/juju/juju/worker/leadership 0.723s

It doesn't happen 100% of the time, but it happens fairly often. I believe the underlying cause is the very short timeout picked in refreshes() - somewhere around a few nanoseconds. I'm investigating a possible fix.

Curtis Hovey (sinzui)
summary: - utopic unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion
+ unit-test failure: TrackerSuite.TestWaitMinionBecomeMinion
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is also seen in vivid unit tests which uses go1.3.3

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

I've spent a couple of hours investigating, managed to find a patch that works - http://paste.ubuntu.com/10620850/ - but then had a discussion with William and he'll take care of this.

Changed in juju-core:
assignee: nobody → William Reade (fwereade)
status: Triaged → In Progress
William Reade (fwereade)
Changed in juju-core:
status: In Progress → Fix Committed
Ian Booth (wallyworld)
Changed in juju-core:
milestone: 1.23-beta1 → 1.24-alpha1
status: Fix Committed → Triaged
Ian Booth (wallyworld)
Changed in juju-core:
assignee: William Reade (fwereade) → Ian Booth (wallyworld)
status: Triaged → In Progress
Ian Booth (wallyworld)
no longer affects: juju-core
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.