python-keystoneclient

Temporary network outage results in connection refused and invalid token

Bug #1150299 reported by Vish Ishaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Undecided
Vish Ishaya
Folsom
Fix Released
Medium
Vish Ishaya
OpenStack Identity (keystone) 2012.2.4
python-keystoneclient
Fix Released
Medium
Vish Ishaya
python-keystoneclient 0.2.3

Bug Description

The auth_token middleware does not retry if it gets an http error. This means a temporary network outage or keystone restart will cause the token to be listed as invalid. The middleware should retry a few times before failing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/23729

Changed in python-keystoneclient:
assignee: nobody → Vish Ishaya (vishvananda)
status: New → In Progress
Revision history for this message
Vish Ishaya (vishvananda) wrote :

keystoneclient fix:
https://review.openstack.org/23728

Changed in keystone:
status: New → In Progress
assignee: nobody → Vish Ishaya (vishvananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/23728
Committed: http://github.com/openstack/python-keystoneclient/commit/9bb29b9dff4d220eaabf86cd286e651c5ae15b98
Submitter: Jenkins
Branch: master

commit 9bb29b9dff4d220eaabf86cd286e651c5ae15b98
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Mar 6 12:10:25 2013 -0800

    Retry http_request and json_request failure.

    Temporary network outages or keystone server restarts can lead
    to a connection refused in auth_token middleware. Rather than
    failing immediately, this patch attempts to retry a few times.

    Fixes bug 1150299

    Change-Id: I2ecf0d7745290976efcb3e3cd6511817a53d3e0a

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/folsom)

Reviewed: https://review.openstack.org/23729
Committed: http://github.com/openstack/keystone/commit/9e0a97d426165842617e55fe74341d06526f9d1e
Submitter: Jenkins
Branch: stable/folsom

commit 9e0a97d426165842617e55fe74341d06526f9d1e
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Mar 19 16:07:07 2013 -0700

    Retry http_request and json_request failure.

    Temporary network outages or keystone server restarts can lead
    to a connection refused in auth_token middleware. Rather than
    failing immediately, this patch attempts to retry a few times.

    Fixes bug 1150299

    (pulled from python-keystoneclient commit
    9bb29b9dff4d220eaabf86cd286e651c5ae15b98)

    Change-Id: I2ecf0d7745290976efcb3e3cd6511817a53d3e0a

tags: added: in-stable-folsom
Mark McLoughlin (markmc)
tags: removed: in-stable-folsom
Changed in keystone:
status: In Progress → Invalid
Revision history for this message
Adam Young (ayoung) wrote :

I think this might be the wrong fix. Instead of retrying a fixed number of times, the auth_token middleware should not record failures in memcached if they are due to a network failure.

Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.2.3
status: Fix Committed → Fix Released
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.