Too much memory allocated for drizzle query

Switching to one of the built in methods where it doesn't require this sort of thing would be a good idea as well.

Thanks for the fix, pushing it now.

gearmand originally used libdrizzle to do the escaping...this change where gearmand did the escaping itself is recent, not sure why.

Totally agree that removing it would be best :)

The latest libdrizzle fixed quoting such it no longer does the 2x
allocation (that design pattern came from MySQL).

On Feb 20, 2013, at 19:55, Keyur <email address hidden> wrote:

> gearmand originally used libdrizzle to do the escaping...this change
> where gearmand did the escaping itself is recent, not sure why.
>
> Totally agree that removing it would be best :)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1130515
>
> Title:
> Too much memory allocated for drizzle query
>
> Status in Gearman Server and Client Libraries:
> In Progress
>
> Bug description:
> Typo in the drizzle queue escape-query code where it reserves
> (query_length * query_length/2) bytes. This obviously gets too heavy
> when the payload is large :)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1130515/+subscriptions

Ah cool!

I see libdrizzle still has the drizzle_escape_string API even in the latest release 5.1.3. Should I change the patch to use that once again?

The version in Libdrizzle 5.1.3 is what we want to target.

Cheers,
 -Brian

On Feb 20, 2013, at 8:29 PM, Keyur <email address hidden> wrote:

> Ah cool!
>
> I see libdrizzle still has the drizzle_escape_string API even in the
> latest release 5.1.3. Should I change the patch to use that once again?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1130515
>
> Title:
> Too much memory allocated for drizzle query
>
> Status in Gearman Server and Client Libraries:
> In Progress
>
> Bug description:
> Typo in the drizzle queue escape-query code where it reserves
> (query_length * query_length/2) bytes. This obviously gets too heavy
> when the payload is large :)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1130515/+subscriptions

I see that the query_escape API signature differs between libdrizzle-5.1.3 and the one in the libdrizzle in drizzle-7.1.36. I haven't compared the other methods yet.

Is libdrizzle-5.1.13 considered a stable release now? This is pretty much the only reason we haven't upgraded yet...

________________________________
 From: Brian Aker <email address hidden>
To: <email address hidden>
Sent: Wednesday, February 20, 2013 11:58 PM
Subject: Re: [Bug 1130515] Re: Too much memory allocated for drizzle query

The version in Libdrizzle 5.1.3 is what we want to target.

Cheers,
    -Brian

On Feb 20, 2013, at 8:29 PM, Keyur <email address hidden> wrote:

> Ah cool!
>
> I see libdrizzle still has the drizzle_escape_string API even in the
> latest release 5.1.3. Should I change the patch to use that once again?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1130515
>
> Title:
>  Too much memory allocated for drizzle query
>
> Status in Gearman Server and Client Libraries:
>  In Progress
>
> Bug description:
>  Typo in the drizzle queue escape-query code where it reserves
>  (query_length * query_length/2) bytes. This obviously gets too heavy
>  when the payload is large :)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1130515/+subscriptions

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1130515

Title:
  Too much memory allocated for drizzle query

Status in Gearman Server and Client Libraries:
  In Progress

Bug description:
  Typo in the drizzle queue escape-query code where it reserves
  (query_length * query_length/2) bytes. This obviously gets too heavy
  when the payload is large :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/gearmand/+bug/1130515/+subscriptions

I see that the query_escape API signature differs between libdrizzle-5.1.3 and the one in the libdrizzle in drizzle-7.1.36. I haven't compared the other methods yet.

Is libdrizzle-5.1.13 considered a stable release now? This is pretty much the only reason we haven't upgraded yet...

What are your feelings about libdrizzle being stable?

On Feb 20, 2013, at 21:35, Keyur <email address hidden> wrote:

> I see that the query_escape API signature differs between
> libdrizzle-5.1.3 and the one in the libdrizzle in drizzle-7.1.36. I
> haven't compared the other methods yet.
>
> Is libdrizzle-5.1.13 considered a stable release now? This is pretty
> much the only reason we haven't upgraded yet...
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1130515
>
> Title:
> Too much memory allocated for drizzle query
>
> Status in Gearman Server and Client Libraries:
> In Progress
>
> Bug description:
> Typo in the drizzle queue escape-query code where it reserves
> (query_length * query_length/2) bytes. This obviously gets too heavy
> when the payload is large :)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1130515/+subscriptions

I actually haven't used it yet :( Read some of the code, but that's it.

If the API is now considered 'done', it might be a good time to mark it as RC. I'll play around a bit this week.

Yes, 5.1.3 is considered stable. We will be making any further API changes to the 5.2 series.

If you have any questions or problems with the API in 5.1.3 please let me know.