Dash - Categories header focus and interactivity
Bug #1045933 reported by
Christian Giordano
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
High
|
Christian Giordano | ||
Unity |
Fix Released
|
High
|
Christopher Townsend | ||
7.2 |
Fix Committed
|
High
|
Christopher Townsend | ||
unity (Ubuntu) |
Fix Released
|
High
|
Christopher Townsend | ||
Trusty |
Fix Released
|
High
|
Unassigned |
Bug Description
The Category Header of any category that is not expandible should not be selectable using either mouse or keyboard navigation as clicking/activating this item does nothing. For the same reason, the header shouldn't react to pointer over events (e.g. if you can't expand the Category Header it should not have a mouse over state)
This also includes the category headers of all flow views because they don't expand vertically.
[Test Case]
1. Open the dash
2. Search for "Brasero"
3. Make sure that the header "Applications" is not selectable (neither with the mouse nor with the keyboard)
[Regression Potential]
None
Related branches
lp://staging/~gordallott/unity/fix-highlight-showing-on-nonexpandable-groups
Rejected
for merging
into
lp://staging/unity
- Andrea Azzarone (community): Disapprove
- Michal Hruby (community): Needs Fixing
-
Diff: 12 lines (+1/-1)1 file modifieddash/PlacesGroup.cpp (+1/-1)
lp://staging/~townsend/unity/fix-dash-no-expand-category
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
-
Diff: 115 lines (+50/-2)4 files modifieddash/DashView.cpp (+34/-0)
dash/DashView.h (+2/-0)
dash/PlacesGroup.cpp (+13/-2)
dash/PlacesGroup.h (+1/-0)
lp://staging/~unity-team/unity/trusty-sru-7.2.6
- Andrea Azzarone (community): Approve
-
Diff: 1554 lines (+547/-141)43 files modifiedCMakeLists.txt (+1/-1)
ChangeLog (+182/-0)
UnityCore/GLibDBusProxy.cpp (+16/-3)
UnityCore/GnomeSessionManager.cpp (+6/-1)
dash/DashController.cpp (+2/-0)
dash/DashController.h (+0/-1)
dash/DashView.cpp (+72/-32)
dash/DashView.h (+3/-3)
dash/PlacesGroup.cpp (+13/-2)
dash/PlacesGroup.h (+1/-0)
dash/ResultView.cpp (+25/-0)
dash/ResultView.h (+6/-4)
dash/ResultViewGrid.cpp (+29/-13)
dash/ScopeView.cpp (+20/-22)
dash/ScopeView.h (+2/-0)
debian/changelog (+51/-0)
decorations/DecoratedWindow.cpp (+5/-0)
decorations/DecoratedWindow.h (+1/-0)
decorations/DecorationsManager.cpp (+5/-1)
hud/HudButton.cpp (+0/-5)
hud/HudController.cpp (+2/-0)
hud/HudController.h (+0/-1)
launcher/DeviceNotificationDisplayImp.cpp (+0/-1)
launcher/LauncherController.cpp (+2/-2)
launcher/LauncherIcon.cpp (+9/-4)
panel/PanelView.cpp (+18/-0)
panel/PanelView.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+16/-2)
plugins/unityshell/unityshell.xml.in (+6/-0)
unity-shared/BGHash.cpp (+5/-2)
unity-shared/CompizUtils.cpp (+0/-3)
unity-shared/OverlayRenderer.cpp (+2/-0)
unity-shared/OverlayScrollView.cpp (+5/-1)
unity-shared/OverlayScrollView.h (+2/-0)
unity-shared/OverlayWindowButtons.cpp (+3/-3)
unity-shared/PlacesOverlayVScrollBar.cpp (+5/-0)
unity-shared/PlacesOverlayVScrollBar.h (+8/-6)
unity-shared/PluginAdapter.cpp (+5/-1)
unity-shared/SearchBar.cpp (+9/-23)
unity-shared/SearchBar.h (+1/-3)
unity-shared/UnitySettings.cpp (+6/-1)
unity-shared/UnitySettings.h (+1/-0)
unity-shared/WindowButtons.cpp (+1/-0)
Changed in ayatana-design: | |
importance: | Undecided → High |
Changed in unity: | |
importance: | Undecided → High |
milestone: | none → backlog |
Changed in ayatana-design: | |
assignee: | nobody → Christian Giordano (nuthinking) |
status: | New → Fix Committed |
Changed in unity: | |
status: | New → Triaged |
tags: | added: dashm udp |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
description: | updated |
Changed in unity: | |
status: | Triaged → In Progress |
assignee: | nobody → Gord Allott (gordallott) |
Changed in unity: | |
milestone: | backlog → none |
tags: | added: exbacklog |
Changed in unity: | |
milestone: | none → 7.0.0 |
Changed in unity: | |
status: | In Progress → Triaged |
assignee: | Gord Allott (gordallott) → nobody |
Changed in unity: | |
milestone: | 7.0.0 → 7.0.1 |
Changed in unity: | |
milestone: | 7.0.1 → 7.1.2 |
Changed in unity: | |
milestone: | 7.1.2 → 7.2.0 |
Changed in unity: | |
milestone: | 7.2.0 → 7.2.1 |
Changed in unity: | |
milestone: | 7.2.1 → 7.2.2 |
Changed in unity: | |
milestone: | 7.2.2 → 7.2.3 |
Changed in unity: | |
milestone: | 7.2.3 → 7.3.1 |
Changed in unity: | |
milestone: | 7.3.1 → 7.3.2 |
Changed in unity: | |
milestone: | 7.3.2 → 7.3.3 |
Changed in unity: | |
assignee: | nobody → Christopher Townsend (townsend) |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | nobody → Christopher Townsend (townsend) |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu Trusty): | |
status: | New → In Progress |
description: | updated |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu Trusty): | |
importance: | Undecided → High |
To post a comment you must log in.
This bug was fixed in the package unity - 7.3.2+15. 10.20150819- 0ubuntu1
--------------- 15.10.20150819- 0ubuntu1) wily; urgency=medium
unity (7.3.2+
[ Andrea Azzarone <email address hidden> ]
* Do not handle events coming from viewports not actually containing
the window. (LP: #1449654)
[ Chris Townsend ]
* Also use the Compiz show() method when forcing an unmapped window to
be visible when clicking on it's active Launcher icon. (LP: #989588)
* When using keyboard navigation in the Dash, skip category headers
that are not expandable. Also, do not highlight the category header
when the mouse cursor is over it. (LP: #1045933)
[ Marco Trevisan (Treviño) ] eQuitDialog: override the background of the window
* ApplicationManager: rely on windows monitor property changes for
updating Pips (LP: #1027191)
* Autopilot: modernize some tests, use stronger methods to ensure
false positive
* DecorationsForc
with transparent color (LP: #1470292)
* Launcher: Always unfold an active icon (LP: #1472339)
* PanelMenuView: ensure that we connect to window signals as soon as
the AppManager knows it (LP: #1472326)
* PlacesGroup: connect to view changes using a function instead of a
lambda (LP: #1470298)
* SessionButton: set button opacity to 75% when pressed (LP: #1301655)
-- CI Train Bot <email address hidden> Wed, 19 Aug 2015 14:45:18 +0000