Comment 2 for bug 1580322

Revision history for this message
Stephane Miller (stephaneeee) wrote :

Hi Mark,

Thanks for filing this. I agree that the usage of skip_install is a bit confusing. It is selectively applied in bifrost-ironic-install because the intent was to still configure and restart services (which that role also does) while avoiding reinstall. This makes it much easier to quickly iterate as a developer when testing small changes since the long installs are skipped.

I feel like due to the current large size and complexity of the role, splitting apart the functions of installing the software, making configuration changes, and (re)starting the involved services could be a good thing. It will serve kolla's purposes as well. However, I want to be very careful that when we decouple those functions we aren't introducing new issues.

I do agree about the rootwrap thing and think we could remove the skip install conditional from there.