skip_install usage appears inconsistent

With a little direction I could probably take on adding the skip_install condition on more install-ish things, or perhaps renaming it to skip_pip_install, creating a (new) skip_install and applying it to non-pip install-ish things, and optionally having skip_install override/set skip_pip_install?

Either of those sound viable?

Hi Mark,

Thanks for filing this. I agree that the usage of skip_install is a bit confusing. It is selectively applied in bifrost-ironic-install because the intent was to still configure and restart services (which that role also does) while avoiding reinstall. This makes it much easier to quickly iterate as a developer when testing small changes since the long installs are skipped.

I feel like due to the current large size and complexity of the role, splitting apart the functions of installing the software, making configuration changes, and (re)starting the involved services could be a good thing. It will serve kolla's purposes as well. However, I want to be very careful that when we decouple those functions we aren't introducing new issues.

I do agree about the rootwrap thing and think we could remove the skip install conditional from there.

The intent was to skip any install task. We now have skip_package_install and skip_install, both in my opinion, do the same thing, just in different areas. I feel like we should consolidate on skip_install though.