Comment 4 for bug 1841157

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

add_hooks_info works, however, there seems certain limitation and something out of current design scope.

For example, check source_xorg.py, there is code flow like:

if is_xorg_input_package(pkg):
  code a
else:
  code b

If I want to get log from code a and b, I need to use code like:

    report.add_hooks_info(None, srcpackage='xserver-xorg-input-evdev')
    report.add_hooks_info(None, srcpackage='xorg')

It does not really work because, the pkg will be "Unknown" because the code get the source pkg from the report object, instead of srcpackage parameter.

Even it works, other code the collect log will run twice, and the will make the code run longer.

(Given we potentially want to add lots of packages, the duplicate log collected will increase.)