have /usr/bin/oem-getlogs in apport to collect all in one logs

Bug #1841157 reported by Yuan-Chen Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Apport
New
Undecided
Unassigned
OEM Priority Project
Fix Released
High
Yuan-Chen Cheng
apport (Ubuntu)
Fix Released
Undecided
Brian Murray

Bug Description

plan to use command like

$ sudo oem-getlogs

to collect all logs that oem project could need.

Tags: oem-priority

Related branches

tags: added: oem-priority
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :
description: updated
Changed in oem-priority:
status: Confirmed → In Progress
summary: - have a oem-logs in apport-symptoms to collect all in one logs
+ have a oem-getlogs /usr/bin to collect all in one logs
summary: - have a oem-getlogs /usr/bin to collect all in one logs
+ have \/usr/bin/oem-getlogs in apport to collect all in one logs
summary: - have \/usr/bin/oem-getlogs in apport to collect all in one logs
+ have /usr/bin/oem-getlogs in apport to collect all in one logs
information type: Proprietary → Public
Changed in apport (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.20.11-0ubuntu14

---------------
apport (2.20.11-0ubuntu14) focal; urgency=medium

  * apport/report.py, test/test_report.py: handle the fact that gdb now
    returns a different error message for truncated core files in some cases.
  * bin/oem-getlogs: add in script for getting hardware enablement related
    logs. Thanks to Yuan-Chen Cheng for the code. (LP: #1841157)
  * apport/hookutils.py: also gather lsusb -v and lsusb -t. Thanks to
    Yuan-Chen Cheng for the patch.
  * bin/oem-getlogs: Various pep8 / pyflakes fixes.

 -- Brian Murray <email address hidden> Fri, 13 Dec 2019 08:41:58 -0800

Changed in apport (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

I just noticed that apport does have the ability to run arbitrary package hooks - see add_hooks_info() in report.py. If you call that you'll be able to resolve the following in oem-getlogs.

" # enable when the feature to include data from package hooks exists."

I believe you'll want something like:

report.add_hooks_info(None, srcpackage='xorg')

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

add_hooks_info works, however, there seems certain limitation and something out of current design scope.

For example, check source_xorg.py, there is code flow like:

if is_xorg_input_package(pkg):
  code a
else:
  code b

If I want to get log from code a and b, I need to use code like:

    report.add_hooks_info(None, srcpackage='xserver-xorg-input-evdev')
    report.add_hooks_info(None, srcpackage='xorg')

It does not really work because, the pkg will be "Unknown" because the code get the source pkg from the report object, instead of srcpackage parameter.

Even it works, other code the collect log will run twice, and the will make the code run longer.

(Given we potentially want to add lots of packages, the duplicate log collected will increase.)

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

just found that oem-getlogs is not listed in debian/apport.install in focal.

Can we include it?

In the mean time, we need the apport-unpack patch so that it can unpack apport.gz file directly. Please check attached patch.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

for #6, create new bug LP: #1859581

Changed in oem-priority:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.