Again, I don't have the source checked out, so I _manually_ edited the patch. It may not apply cleanly.
Note for the upstream bug[1], that this function has changed in master. It now calls https://git.xfce.org/xfce/xfce4-session/tree/xfce4-session/xfce-screensaver.c#n484.
That function still has that bug in the SCREENSAVER_TYPE_OTHER case.
The fix should look similar to what I attached. I might write a patch in a few weeks if you don't beat me to it. :)
Why didn't the compiler warn about the uninitialized variable? Don't you use -Wuninitialized (or -Wall for developing)?
My first corrected patch is still not checking the return value of g_spawn_ command_ line_sync( ). /developer. gnome.org/ glib/stable/ glib-Spawning- Processes. html#g- spawn-command- line-sync
https:/
Fixed this now.
Again, I don't have the source checked out, so I _manually_ edited the patch. It may not apply cleanly.
Note for the upstream bug[1], that this function has changed in master. It now calls /git.xfce. org/xfce/ xfce4-session/ tree/xfce4- session/ xfce-screensave r.c#n484. TYPE_OTHER case.
https:/
That function still has that bug in the SCREENSAVER_
The fix should look similar to what I attached. I might write a patch in a few weeks if you don't beat me to it. :)
[1]: https:/ /bugzilla. xfce.org/ show_bug. cgi?id= 10089