I guess the commit message could have been clearer.
Windows (to be clear MSVC) is handled in a completely different way and has not been touched by the commit (at least that's what I hope/understand from the code in src/CMakeLIsts.txt).
For everything using standard build toolchain (so at least Linux/*BSD/MacOS) with GCC/LLVM your statement is true, there is no way to have an entirely static build now. But there has not been a way before without tinkering with the CMakeLIsts files, so I thought this wouldn't be dramatic.
If we want to enable static linking with standard build toolchain on Linux/*BSD/MacOS with GCC/LLVM, we should make a proper approach to do this.
But we should create a new bug for this, I think. We should then also make sure if we want to officially support static building for everyone or maybe issue a warning if static building is enabled that the user doing so is on his own when it comes to such issues like we had in this bug. Such issues are very hard to trace since it depends heavily on the system where the error occurs.
I guess the commit message could have been clearer. txt).
Windows (to be clear MSVC) is handled in a completely different way and has not been touched by the commit (at least that's what I hope/understand from the code in src/CMakeLIsts.
For everything using standard build toolchain (so at least Linux/*BSD/MacOS) with GCC/LLVM your statement is true, there is no way to have an entirely static build now. But there has not been a way before without tinkering with the CMakeLIsts files, so I thought this wouldn't be dramatic.
If we want to enable static linking with standard build toolchain on Linux/*BSD/MacOS with GCC/LLVM, we should make a proper approach to do this.
But we should create a new bug for this, I think. We should then also make sure if we want to officially support static building for everyone or maybe issue a warning if static building is enabled that the user doing so is on his own when it comes to such issues like we had in this bug. Such issues are very hard to trace since it depends heavily on the system where the error occurs.