widelands

Cmake fails to recreate locale and/or po directory correctly when .pot or .po files have changed in source

Bug #561308 reported by SirVer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build16-rc1

Bug Description

I am at trunk 5206. I have an old cmake build directory around which I use to rebuild widelands. Doing make lang looks like everything works properly, but upon running widelands, some strings are not translated. Directly running utils/build_locale.py and pointing widelands to the directory via --localedir shows all strings as translated.

Deleting the po and locale dir in the build directory didn't help: the directories are recreated upon make lang, but the symptoms remain.

Related branches

lp://staging/~qcumber-some/widelands/spice-up-cmake
Widelands Developers: Pending requested
Diff: 0 lines
SirVer (sirver)
Changed in widelands:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Jens Beyer (Qcumber-some) (qcumber-some)
tags: added: buildsystem cmake
Revision history for this message
Jens Beyer (qcumber-some) wrote :

Does it help if you run the cmake command on the old build directory again?
If not, it is really a bug. If this helps, it is "by design" (but not nice).

Revision history for this message
Jens Beyer (qcumber-some) wrote :

Added a warning in spice-up-cmake branch if translations are new, compared to older cmake runs. It is not possible to do this automatically, but the warning should be good enough.

Revision history for this message
SirVer (sirver) wrote :

Nope, running cmake does not help. The problem still persists:

$ cd widelands.build
$ make clean all lang
- Some stuff is untranslated, some is translated
$ rm -rf po locale && cmake ../bzr_repo && make clean all lang
- Problem is persistent: some stuff is translated, some not

The current fix for me is:
$ rm -rf po locale && cd ../bzr_repo && utils/buildlocale.py && mv locale ../widelands.build && cd ../widelands.build
- Everything is properly translated.

Revision history for this message
Jens Beyer (qcumber-some) wrote :

I guess the warning, available on spice-up-cmake branch, will do. If not, this bug may be reopened.

Changed in widelands:
status: Confirmed → In Progress
assignee: Jens Beyer (Qcumber-some) (qcumber-some) → nobody
SirVer (sirver)
Changed in widelands:
milestone: none → build16-rc1
Jens Beyer (qcumber-some)
Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
SirVer (sirver) wrote :

Released in build16-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.