rabbit: drain_events is sometimes called with None
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
oslo.messaging |
Fix Released
|
High
|
Mehdi Abaakouk | ||
oslo.messaging (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
High
|
James Page | ||
Utopic |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
Hi,
In rabbit driver, kombu.connectio
Cheers,
---- ---- ---- ---- ----
[Impact]
* This patch along with those from LP #1400268 and LP #1338732 fixes rabbitmq reconnects
* We are backporting this to Icehouse since oslo.messaging 1.3.0
fails to reconnect to Rabbit properly, particularly nova-compute.
* This patch alond with it's dependencies metnioend above, will ensure that
multiple reconnect attempts happen by having connections timout and retry.
[Test Case]
* Start a service that uses oslo.messaging with rabbitmq e.g. nova-compute
* Stop rabbitmq while tail-F /var/log/
* Observe that nova-compute amqp times out and it is trying to reconnect
* Restart rabbitmq
* Observe that rabbitmq connection has re-established
[Regression Potential]
* None. I have tested in my local cloud environment and it appears to be
reliable.
Changed in oslo.messaging: | |
importance: | Undecided → High |
Changed in oslo.messaging: | |
assignee: | nobody → Mehdi Abaakouk (sileht) |
status: | New → In Progress |
Changed in oslo.messaging: | |
milestone: | none → next-kilo |
Changed in oslo.messaging: | |
status: | Fix Committed → Fix Released |
description: | updated |
tags: | added: icehouse-backport-potential |
Changed in oslo.messaging (Ubuntu): | |
status: | New → Fix Released |
Changed in oslo.messaging (Ubuntu Trusty): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in oslo.messaging (Ubuntu Trusty): | |
status: | Triaged → In Progress |
assignee: | nobody → James Page (james-page) |
tags: | removed: icehouse-backport-potential |
Reviewed: https:/ /review. openstack. org/145521 /git.openstack. org/cgit/ openstack/ oslo.messaging/ commit/ ?id=44132d43449 02f98007e6e58ea 3bee56c701b400
Committed: https:/
Submitter: Jenkins
Branch: master
commit 44132d4344902f9 8007e6e58ea3bee 56c701b400
Author: Mehdi Abaakouk <email address hidden>
Date: Wed Jan 7 15:49:54 2015 +0100
rabbit: fix timeout timer when duration is None
When the duration of the timeout timer used in the rabbit driver.is
None and we want that the timer return a maximum of N secs it return None
(infinite) instead of N.
This change fixes that.
Closes-bug: #1408370
Change-Id: I7f4cb3075f776c 63aa7dc49717367 7f92b68c16d