Hi,
I have taken a look at the patch. Great work. I just ran tests with the
code in the teardown. This saved a ton of memory.
If I was you. I'd add this in the first patch. In an additional one I'd
add the changes for the networks, subnets etc.
It will certainly help speed up the approval process.
Thanks
Gary
On 11/22/2012 11:00 AM, Iryoung Jeong wrote:
> One more try :)
>
> I found another clue which ate memory, so I took the liberty of
> uploading new review.
>
> With new patch, unit tests can run under 250M RES.
>
> It looks like there's still more place to improve, but I think sharing
> early would be better.
>
Hi,
I have taken a look at the patch. Great work. I just ran tests with the
code in the teardown. This saved a ton of memory.
If I was you. I'd add this in the first patch. In an additional one I'd
add the changes for the networks, subnets etc.
It will certainly help speed up the approval process.
Thanks
Gary
On 11/22/2012 11:00 AM, Iryoung Jeong wrote:
> One more try :)
>
> I found another clue which ate memory, so I took the liberty of
> uploading new review.
>
> With new patch, unit tests can run under 250M RES.
>
> It looks like there's still more place to improve, but I think sharing
> early would be better.
>