Comment 44 for bug 2000186

Looking at this during a patch-pilot shift and thought I'd add a quick note here, being somewhat (intimately) familiar with dh's systemd restart behaviour.

I concur with vorlon's observation that the d/rules in this package seems excessively "manual" (explicitly calling the various dh scripts). However, while I'd certainly say it's worth bringing the package up to modern standards the restart behaviour will need *very* careful testing. Some things to be aware of:

* dh systemd restart defaults change (in compat version 10 ... I think?) from stop->install->start to install->restart. Because this package doesn't explicitly select a restart behaviour it'll be affected by the default changing (if it moves beyond dh level 9).

* In LP: #1959054 we changed the behaviour of debhelper's stop->install->start method to run the stop phase in the preinst of the current version, rather than the prerm of the old version (see the ticket for more details). This will also potentially affect this package, should it upgrade (the change was in dh_installsystemd which this package doesn't currently use but which it will have to if it moves to dh-compat >9).

Again, this *shouldn't* affect this bug (I don't think? I've only skimmed the comments thus far though), but it's worth bearing in mind for future iterations.