Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1988711

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Jeff, Thanks for the quickly providing the test kernel. It passed the sanity test.

Any ETA of the release build with integration of these patches for our QA team to verify.

Hi, could you please update the summary with a test case that verifies this fix?

PRs made for both Jammy and Kinetic. Kinetic was only missing the last 6 patches.

Hi Jeff,

Do you have the kernel version which has these lpfc patches integrated? If not, any ETA?

Hi Arvind,

The Kinetic (5.19) ones went in pretty easily and are likely to be in the
next SRU kernel for 5.19. The Jammy pull (5.15) is another story. In the
time it took for me to apply all 100ish patches and submit my tree, the
kernel team had made a ton of stable updates and when they went to apply my
changes for this, there were numerous conflicts and duplicates. So I'm
going to have to now go through all 100 or so patches and figure out what
needs to be pulled and what isn't cleanly applying otherwise.

Cheers
Jeff

--
Jeff Lane
Engineering Manager
IHV/OEM Alliances and Server Certification

"Entropy isn't what it used to be."

On Tue, Oct 18, 2022 at 6:40 AM Aravind Valloor Mana <
<email address hidden>> wrote:

> Hi Jeff,
>
> Do you have the kernel version which has these lpfc patches integrated?
> If not, any ETA?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1988711
>
> Title:
> Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 for Ubuntu 22.04
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Jammy:
> In Progress
> Status in linux source package in Kinetic:
> In Progress
>
> Bug description:
> [IMPACT/Justification]
> There are numerous bug fixes included in the more recent version of lpfc
> That Broadcom has asked to pull into Jammy and Kinetic to better support
> customers in the field who are using the GA kernel and cant or wont move to
> the HWE kernels. These all are limited to the lpfc driver itself, no
> patches to core code are requested.
>
> [FIX]
> A few of these were already landed in Jammy, and all but 6 (ones landed
> in 6.0 upstream) were already in Kinetic.
>
> b3d11f195cbb scsi: lpfc: Copyright updates for 14.2.0.5 patches
> 71faf8d30fdb scsi: lpfc: Update lpfc version to 14.2.0.5
> b21c9deb1479 scsi: lpfc: Refactor lpfc_nvmet_prep_abort_wqe() into
> lpfc_sli_prep_abort_xri()
> ffc566411ade scsi: lpfc: Revert RSCN_MEMENTO workaround for misbehaved
> configuration
> ea92e173dc55 scsi: lpfc: Fix lost NVMe paths during LIF bounce stress
> test
> 2f67dc7970bc scsi: lpfc: Fix possible memory leak when failing to issue
> CMF WQE
> 0948a9c53860 scsi: lpfc: Remove extra atomic_inc on cmd_pending in
> queuecommand after VMID
> 35251b4d79db scsi: lpfc: Set PU field when providing D_ID in
> XMIT_ELS_RSP64_CX iocb
> f8191d40aa61 scsi: lpfc: Prevent buffer overflow crashes in debugfs with
> malformed user input
> 4ecc9b0271a7 scsi: lpfc: Fix uninitialized cqe field in
> lpfc_nvme_cancel_iocb()
> 1af48fffd7ff scsi: lpfc: Update lpfc version to 14.2.0.4
> 2e7e9c0c1ec0 scsi: lpfc: Allow reduced polling rate for
> nvme_admin_async_event cmd completion
> ea7bd1f39331 scsi: lpfc: Add more logging of cmd and cqe information for
> aborted NVMe cmds
> 336d63615466 scsi: lpfc: Fix port stuck in bypassed state after LIP in
> PT2PT topology
> b1b3440f437b scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO
> is aborted
> 6f808bd78e82 scsi: lpfc: Address NULL pointer dereference after
> starget_to_rport()
> e27f05147bff scsi: lpfc: Resolve some cleanup is...

>>In the time it took for me to apply all 100ish patches and submit my tree, the
>>kernel team had made a ton of stable updates and when they went to apply my
>>changes for this, there were numerous conflicts and duplicates.

Jeff, Do you need any help from our end for these conflicts and duplicates on Jammy?

Hi Aravind,

That would be most helpful. I've spent a bunch of time trying to find the
missing packages but still haven't been able to really figure out what is
missing and what is unneeded at this point. Several of the original patch
list have been merged in by doing some stable release updates from
upstream, but there are still conflicts I've been unable to resolve. ( my
apologies, my Git is fairly weak)

This is the feedback I got from the kernel team when they tried merging my
original PR into our Jammy tree:

I noticed issues with ('scsi: lpfc: SLI path split: Refactor SCSI paths'),
('scsi: lpfc: Remove unneeded variable'), and ('scsi: lpfc: Resolve NULL
ptr dereference after an ELS LOGO is aborted'). There are also a half
dozen duplicate patches.

Could you refactor that list of patches against the current updated tree of
jammy/master-next

https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy

and I'll retry this...

FWIW, this has been committed to Kinetic so that much is done at least.

Cheers
Jeff

On Wed, Nov 2, 2022 at 9:27 AM Aravind Valloor Mana <
<email address hidden>> wrote:

> >>In the time it took for me to apply all 100ish patches and submit my
> tree, the
> >>kernel team had made a ton of stable updates and when they went to apply
> my
> >>changes for this, there were numerous conflicts and duplicates.
>
> Jeff, Do you need any help from our end for these conflicts and
> duplicates on Jammy?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1988711
>
> Title:
> Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 for Ubuntu 22.04
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Jammy:
> In Progress
> Status in linux source package in Kinetic:
> In Progress
>
> Bug description:
> [IMPACT/Justification]
> There are numerous bug fixes included in the more recent version of lpfc
> That Broadcom has asked to pull into Jammy and Kinetic to better support
> customers in the field who are using the GA kernel and cant or wont move to
> the HWE kernels. These all are limited to the lpfc driver itself, no
> patches to core code are requested.
>
> [FIX]
> A few of these were already landed in Jammy, and all but 6 (ones landed
> in 6.0 upstream) were already in Kinetic.
>
> b3d11f195cbb scsi: lpfc: Copyright updates for 14.2.0.5 patches
> 71faf8d30fdb scsi: lpfc: Update lpfc version to 14.2.0.5
> b21c9deb1479 scsi: lpfc: Refactor lpfc_nvmet_prep_abort_wqe() into
> lpfc_sli_prep_abort_xri()
> ffc566411ade scsi: lpfc: Revert RSCN_MEMENTO workaround for misbehaved
> configuration
> ea92e173dc55 scsi: lpfc: Fix lost NVMe paths during LIF bounce stress
> test
> 2f67dc7970bc scsi: lpfc: Fix possible memory leak when failing to issue
> CMF WQE
> 0948a9c53860 scsi: lpfc: Remove extra atomic_inc on cmd_pending in
> queuecommand after VMID
> 35251b4d79db scsi: lpfc: Set PU field when providing D_ID in
> XMIT_ELS_RSP64_CX iocb
> f8191d40aa61 scsi: lpfc: Prevent buffer overflow crashes in debugfs with
> malformed user input
> 4ecc9b0271a7 scsi: lpfc: Fix uninitialized cqe...

From: Ketan Mukadam <email address hidden>
Sent: Friday, November 18, 2022 10:13 AM
To: 'Jeffrey Lane' <email address hidden>
Subject: Ubuntu Jammy lpfc patche merges

Jeff,

The jammy/master-next has lot of cherry picked patches which has broken lpfc…. that is why it is challenging to merge patches…. Ideally all the Refactor patches should have been pulled together, but I see just 3 Refactor patches in master-next breaking the lpfc completely. Many lpfc patches out of the lpfc patch-set attached in the bug 1988711, there are many duplicates already present in master-next….

So I was able to fix it by selectively merging patches…. I am attaching the list of 76 patches that you can try to merge (there could be minor merge conflicts that are easy to resolve).

There is also dependency on nvme-fc transport patches not pulled into kernel master-next.

https://www.spinics.net/lists/linux-scsi/msg173218.html

Apart from these patches, the below 3 lpfc patches may have some other dependency, which I have not looked into….may depend on some kernel-wide patches.

scsi-lpfc-Remove-failing-soft_wwn-support.patch
scsi-lpfc-Fix-attempted-FA-PWWN-usage-after-feature-.patch
scsi-lpfc-Remove-Menlo-Hornet-related-code.patch

Hope this helps!!

Thanks
Ketan

Jeff, Let us know if you are hitting any further merge issues in updating lpfc patches for Jammy. Thanks

This bug is awaiting verification that the linux/5.19.0-27.28 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Jeff,

Please find attached the lpfc patches that update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 for Ubuntu 22.04.

There are 97 patches in the tar file (96 lpfc patches + nvme-fc transport patch for dependency resolution). I have also added upstream_commitids.log file that mentions all the upstream commit ids.

Following steps were performed

1) Cloned the git tree (master-next repo) from

https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy

2) Apply each lpfc patch and resolve issues. The cover letter explains the dependency resolution details for few patches.

3) Build the kernel (5.15.78), upgrade kernel on current Ubuntu 22.04 and sanity test the new kernel with updated lpfc driver. All tests passed with lpfc driver 14.2.0.5 version.

The attached lpfc patches should now cleanly apply to the current jammy master-next repo. Please let me know if you are still hitting any issue.

This bug was fixed in the package linux - 5.19.0-28.29

---------------
linux (5.19.0-28.29) kinetic; urgency=medium

  * kinetic/linux: 5.19.0-28.29 -proposed tracker (LP: #1999746)

  * mm:vma05 in ubuntu_ltp fails with '[vdso] bug not patched' on kinetic/linux
    5.19.0-27.28 (LP: #1999094)
    - fix coredump breakage

linux (5.19.0-27.28) kinetic; urgency=medium

  * kinetic/linux: 5.19.0-27.28 -proposed tracker (LP: #1997794)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2022.11.14)

  * selftests/.../nat6to4 breaks the selftests build (LP: #1996536)
    - [Config] Disable selftests/net/bpf/nat6to4

  * Expose built-in trusted and revoked certificates (LP: #1996892)
    - [Packaging] Expose built-in trusted and revoked certificates

  * support for same series backports versioning numbers (LP: #1993563)
    - [Packaging] sameport -- add support for sameport versioning

  * Add cs35l41 firmware loading support (LP: #1995957)
    - ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code
    - ASoC: cs35l41: Add common cs35l41 enter hibernate function
    - ASoC: cs35l41: Do not print error when waking from hibernation
    - ALSA: hda: cs35l41: Don't dereference fwnode handle
    - ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations
    - ALSA: hda: cs35l41: Drop wrong use of ACPI_PTR()
    - ALSA: hda: cs35l41: Consolidate selections under SND_HDA_SCODEC_CS35L41
    - ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls
    - ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly
    - ALSA: hda: cs35l41: Save codec object inside component struct
    - ALSA: hda: cs35l41: Add initial DSP support and firmware loading
    - ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver
    - ALSA: hda: cs35l41: Support reading subsystem id from ACPI
    - ALSA: hda: cs35l41: Support multiple load paths for firmware
    - ALSA: hda: cs35l41: Support Speaker ID for laptops
    - ALSA: hda: cs35l41: Support Hibernation during Suspend
    - ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables
    - ALSA: hda: hda_cs_dsp_ctl: Add fw id strings
    - ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence
    - ALSA: hda: cs35l41: Support Firmware switching and reloading
    - ALSA: hda: cs35l41: Add module parameter to control firmware load
    - Revert "ALSA: hda: cs35l41: Allow compilation test on non-ACPI
      configurations"
    - ALSA: hda/realtek: More robust component matching for CS35L41
    - [Config] updateconfigs for SND_HDA_CS_DSP_CONTROLS

  * Fibocom WWAN FM350-GL suspend error (notebook not suspend) (LP: #1990700)
    - net: wwan: t7xx: Add AP CLDMA

  * Screen cannot turn on after screen off with Matrox G200eW3 [102b:0536]
    (LP: #1995573)
    - drm/mgag200: Optimize damage clips
    - drm/mgag200: Add FB_DAMAGE_CLIPS support
    - drm/mgag200: Enable atomic gamma lut update

  * TEE Support for CCP driver (LP: #1991608)
    - crypto: ccp: Add support for TEE for PCI ID 0x14CA

  * AMD Cezanne takes 5 minutes to wake up from suspend (LP: #1993715)
    - platform/x86/amd: pmc: Read...

Jeff, any update for merging patches into Jammy? Thanks

This bug is awaiting verification that the linux-ibm/5.19.0-1015.16 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Hi Ketan,

Thanks for this. I'm waiting on advice from the kernel team now.. I'm not
sure if I should send a PR based on the branch I patched using your patch
set, or if I should just send the patch set directly to the kernel team ML
for consideration. Indeed I was able to successfully apply all the patches
to a fresh master-next branch so now I just need to get advice on the best
way to request the inclusion.

Thanks
Jeff

On Mon, Jan 9, 2023 at 12:05 AM Ketan Mukadam <email address hidden>
wrote:

> Jeff, any update for merging patches into Jammy? Thanks
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1988711
>
> Title:
> Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 for Ubuntu 22.04
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Jammy:
> In Progress
> Status in linux source package in Kinetic:
> Fix Released
>
> Bug description:
> [IMPACT/Justification]
> There are numerous bug fixes included in the more recent version of lpfc
> That Broadcom has asked to pull into Jammy and Kinetic to better support
> customers in the field who are using the GA kernel and cant or wont move to
> the HWE kernels. These all are limited to the lpfc driver itself, no
> patches to core code are requested.
>
> [FIX]
> A few of these were already landed in Jammy, and all but 6 (ones landed
> in 6.0 upstream) were already in Kinetic.
>
> b3d11f195cbb scsi: lpfc: Copyright updates for 14.2.0.5 patches
> 71faf8d30fdb scsi: lpfc: Update lpfc version to 14.2.0.5
> b21c9deb1479 scsi: lpfc: Refactor lpfc_nvmet_prep_abort_wqe() into
> lpfc_sli_prep_abort_xri()
> ffc566411ade scsi: lpfc: Revert RSCN_MEMENTO workaround for misbehaved
> configuration
> ea92e173dc55 scsi: lpfc: Fix lost NVMe paths during LIF bounce stress
> test
> 2f67dc7970bc scsi: lpfc: Fix possible memory leak when failing to issue
> CMF WQE
> 0948a9c53860 scsi: lpfc: Remove extra atomic_inc on cmd_pending in
> queuecommand after VMID
> 35251b4d79db scsi: lpfc: Set PU field when providing D_ID in
> XMIT_ELS_RSP64_CX iocb
> f8191d40aa61 scsi: lpfc: Prevent buffer overflow crashes in debugfs with
> malformed user input
> 4ecc9b0271a7 scsi: lpfc: Fix uninitialized cqe field in
> lpfc_nvme_cancel_iocb()
> 1af48fffd7ff scsi: lpfc: Update lpfc version to 14.2.0.4
> 2e7e9c0c1ec0 scsi: lpfc: Allow reduced polling rate for
> nvme_admin_async_event cmd completion
> ea7bd1f39331 scsi: lpfc: Add more logging of cmd and cqe information for
> aborted NVMe cmds
> 336d63615466 scsi: lpfc: Fix port stuck in bypassed state after LIP in
> PT2PT topology
> b1b3440f437b scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO
> is aborted
> 6f808bd78e82 scsi: lpfc: Address NULL pointer dereference after
> starget_to_rport()
> e27f05147bff scsi: lpfc: Resolve some cleanup issues following SLI path
> refactoring
> 24e1f056677e scsi: lpfc: Resolve some cleanup issues following abort
> path refactoring
> 44ba9786b673 scsi: lpfc: Correct BDE type for XMIT_SEQ64_WQE in
> lpfc_ct_reject_event()
> a5b168efba21 scsi: lpfc: Add support for ATTO...

Thank you for letting us know what's going and please do continue to keep us posted.

Laurie

This bug is awaiting verification that the linux-aws/5.19.0-1018.19 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

This bug is awaiting verification that the linux-azure/5.19.0-1017.18 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

This bug is awaiting verification that the linux-aws-5.19/5.19.0-1019.20~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

This bug is awaiting verification that the linux-lowlatency-hwe-5.19/5.19.0-1017.18~22.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Update: Everything applied fine, but my PR got kicked back again because they didn't like how I did it (I ended up doing a single commit with all the patches, so I need to now go back and redo this with a commit for each individual patch)

I'll work on that today and tomorrow and try to get a new PR by friday afternoon.

Jeff can you or anyone at Canonical please tell me what is going on with this patch set?

Did it finally make it into a kernel?

Laurie

Hi Laurie,

This update is in the Kinetic (5.19) kernel. It has not made it into Jammy 5.15 yet.

Michael, that is the same status we’ve had for quite some time now.

On Wed, Apr 12, 2023 at 8:06 PM Michael Reed <email address hidden>
wrote:

> Hi Laurie,
>
> This update is in the Kinetic (5.19) kernel. It has not made it into
> Jammy 5.15 yet.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1988711
>
> Title:
> Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Jammy:
> In Progress
> Status in linux source package in Kinetic:
> Fix Released
>
> Bug description:
> [IMPACT/Justification]
> There are numerous bug fixes included in the more recent version of lpfc
> That Broadcom has asked to pull into Jammy and Kinetic to better support
> customers in the field who are using the GA kernel and cant or wont move to
> the HWE kernels. These all are limited to the lpfc driver itself, no
> patches to core code are requested.
>
> [FIX]
> A few of these were already landed in Jammy, and all but 6 (ones landed
> in 6.0 upstream) were already in Kinetic.
>
> b3d11f195cbb scsi: lpfc: Copyright updates for 14.2.0.5 patches
> 71faf8d30fdb scsi: lpfc: Update lpfc version to 14.2.0.5
> b21c9deb1479 scsi: lpfc: Refactor lpfc_nvmet_prep_abort_wqe() into
> lpfc_sli_prep_abort_xri()
> ffc566411ade scsi: lpfc: Revert RSCN_MEMENTO workaround for misbehaved
> configuration
> ea92e173dc55 scsi: lpfc: Fix lost NVMe paths during LIF bounce stress
> test
> 2f67dc7970bc scsi: lpfc: Fix possible memory leak when failing to issue
> CMF WQE
> 0948a9c53860 scsi: lpfc: Remove extra atomic_inc on cmd_pending in
> queuecommand after VMID
> 35251b4d79db scsi: lpfc: Set PU field when providing D_ID in
> XMIT_ELS_RSP64_CX iocb
> f8191d40aa61 scsi: lpfc: Prevent buffer overflow crashes in debugfs with
> malformed user input
> 4ecc9b0271a7 scsi: lpfc: Fix uninitialized cqe field in
> lpfc_nvme_cancel_iocb()
> 1af48fffd7ff scsi: lpfc: Update lpfc version to 14.2.0.4
> 2e7e9c0c1ec0 scsi: lpfc: Allow reduced polling rate for
> nvme_admin_async_event cmd completion
> ea7bd1f39331 scsi: lpfc: Add more logging of cmd and cqe information for
> aborted NVMe cmds
> 336d63615466 scsi: lpfc: Fix port stuck in bypassed state after LIP in
> PT2PT topology
> b1b3440f437b scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO
> is aborted
> 6f808bd78e82 scsi: lpfc: Address NULL pointer dereference after
> starget_to_rport()
> e27f05147bff scsi: lpfc: Resolve some cleanup issues following SLI path
> refactoring
> 24e1f056677e scsi: lpfc: Resolve some cleanup issues following abort
> path refactoring
> 44ba9786b673 scsi: lpfc: Correct BDE type for XMIT_SEQ64_WQE in
> lpfc_ct_reject_event()
> a5b168efba21 scsi: lpfc: Add support for ATTO Fibre Channel devices
> 348efeca7487 scsi: lpfc: Rework lpfc_vmid_get_appid() to be protocol
> independent
> ed913cf4a533 scsi: lpfc: Commonize VMID code location
> fcb9e738667c scsi: lpfc: Update lpfc version to 14.2.0.3
> a14396b6d139 scsi: lpfc: Use sg_dma_address() and sg_dma_len() macros
> for NVMe I/O
> e6f5104145...

Current status:
I had to apply all the patches to a much older kernel because there are conflicts when cherry picking on the latest version on master-next.

After applying the patches successfully on tag: Ubuntu-5.15.0-56.62 I started rebasing each tag in sequence trying to find where it first breaks.

I made it to Ubuntu-5.15.0-58.64 successfully and when I then rebased on Ubuntu-5.15.0-59.65 the cherrypicks start failing.

I got stuck trying to find what was pulled in between those two tag that's causing the conflict. As the advice I got from the kernel team was "everything should be a clean cherry pick except for the backported patches" I ended up banging my head trying to find the culprit. Then resources became an issue. Michael has also started looking at this to put fresh eyes on it and also since I'm finding I have even less time (and too many things going on at once).

Michael is now taking a look to figure out what changed between those two tags.

Yes Jeff, this is the same explanation and status we’ve already heard.

Hi Ketan,

I found that the following patches are currently in our tree and revert the patches listed below.
Revert
Revert "scsi: lpfc: SLI path split: Refactor lpfc_iocbq"
Revert "scsi: lpfc: SLI path split: Refactor fast and slow paths to native SLI4"
Revert "scsi: lpfc: SLI path split: Refactor SCSI paths"
Revert "scsi: lpfc: Fix locking for lpfc_sli_iocbq_lookup()"
Revert "scsi: lpfc: Fix element offset in __lpfc_sli_release_iocbq_s4()"
Revert "scsi: lpfc: Resolve some cleanup issues following SLI path refactoring"

Patches not needed:
a680a9298e7b scsi: lpfc: SLI path split: Refactor lpfc_iocbq
1b64aa9eae28 scsi: lpfc: SLI path split: Refactor fast and slow paths to native SLI4
3512ac094293 scsi: lpfc: SLI path split: Refactor SCSI paths
c26bd6602e1d scsi: lpfc: Fix locking for lpfc_sli_iocbq_lookup()
84c6f99e3907 scsi: lpfc: Fix element offset in __lpfc_sli_release_iocbq_s4()
e27f05147bff scsi: lpfc: Resolve some cleanup issues following SLI path refactoring

Are there any other patches that have been reverted upstream that I need to know about? Most of the issues that I am seeing now are with iocb_cmpl being changed to cmd_cmpl. The "Revert" patches do the opposite and I doing the same.

Hi Michael,

We recommend that you do not revert these patches and merge all the lpfc patches provided in this bug description.

The reason you see revert patches in 5.15 stable tree is because, the tree partially merged only few "path split" patches causing issues.

This is explained by James in the patchset for stable tree.

https://www.spinics.net/lists/stable/msg603453.html

For Jammy, I would recommend taking all the patches that we submitted (the patchset already has all the "path split" patches in correct sequence).

Let me know if you have any questions.

Hi Ketan,

Are you stating that I should not apply the Revert patches at all?

Revert "scsi: lpfc: SLI path split: Refactor lpfc_iocbq"
Revert "scsi: lpfc: SLI path split: Refactor fast and slow paths to native SLI4"
Revert "scsi: lpfc: SLI path split: Refactor SCSI paths"
Revert "scsi: lpfc: Fix locking for lpfc_sli_iocbq_lookup()"
Revert "scsi: lpfc: Fix element offset in __lpfc_sli_release_iocbq_s4()"
Revert "scsi: lpfc: Resolve some cleanup issues following SLI path refactoring"

>>Are you stating that I should not apply the Revert patches at all?

Yes, revert patches are not required since the plan is to merge _all_ "path split" patches in Jammy (as part of the provided patchset).

Hi Ketan,

Currently the reverted patches have already been pulled into our master-next kernel because they are apart of the upstream kernel. Cherry picking the affected patches on top of those causes all types of issues. We need a solution with those reverted patches in place. Can you provide a revised list of commits that takes the reverted patches into account?

Michael and team,

Some history for the context:

- Sep 2022 we submitted the bug with updated lpfc patch set on Jammy tree (master)
- Oct 2022 the patches got integrated into kinetic kernel (non-LTS) but Jammy had merge issues.
- Dec 2022 we got asked to rework the lpfc patches since Jammy kernel tree has moved ahead.
- Dec 2022 we reworked on the lpfc patches on Jammy tree's (master-next) repo (submitted 97 lpfc patches)
- We also tested the sandbox kernel build and did a basic EVT on Jammy kernel before patch submission.
- May 2023 we are again asked to revise the list of lpfc patches due to changes in their Jammy kernel tree

At this junction we have done our due diligence to work with Canonical to get our driver updated. We are not in a position to commit additional resources to reworking these patches again with no guarantees it will lead to a successful outcome and we have not received any customer support issues on this OS since it GA'd a year ago.

We will leave it up to Canonical to do what they will with the patches provided.

Should a customer critical issue arise, we will deal with it at that time.

Laurie Barry
Broadcom Emulex Software Program Manager

If a critical

I have created a test kernel can anyone provide feedback?

https://people.canonical.com/~mreed/misc/lp_1988711_lpfc_14_2_0_5/

Thanks Michael, we will get this test kernel sanity tested and update the results.

Michael, can you confirm that the lpfc driver is updated to 14.2.0.5 in the provided kernel?

I installed the kernel but the driver version shown is 14.0.0.4. I also untar the deb file and the modinfo on the lpfc.ko also shows 14.0.0.4.

root@evt:~/tmp/lib/modules/5.15.0-58-generic/kernel/drivers/scsi/lpfc# modinfo ./lpfc.ko
filename: /root/tmp/lib/modules/5.15.0-58-generic/kernel/drivers/scsi/lpfc/./lpfc.ko
version: 0:14.0.0.4
author: Broadcom
description: Emulex LightPulse Fibre Channel SCSI driver 14.0.0.4

Michael any update?