Comment 38 for bug 1670041

Eric,

Is this patch the basis for a more permanent and general fix (it seems not specific to ath10k)?

Thanks!

The patch produces a marked improvement with TCP from the local QCA6174 client to AP/remote.

4.12.0 (UDP; no patch)

% iperf3 -u -b 1000M -c remote
Connecting to host remote, port 5201
[ 4] local local port 42530 connected to remote port 5201
[ ID] Interval Transfer Bandwidth Total Datagrams
[ 4] 0.00-1.00 sec 14.8 MBytes 124 Mbits/sec 10725
[ 4] 1.00-2.00 sec 17.8 MBytes 150 Mbits/sec 12924
[ 4] 2.00-3.00 sec 19.0 MBytes 160 Mbits/sec 13773
[ 4] 3.00-4.00 sec 18.1 MBytes 152 Mbits/sec 13118
[ 4] 4.00-5.00 sec 18.7 MBytes 157 Mbits/sec 13555
[ 4] 5.00-6.00 sec 18.0 MBytes 151 Mbits/sec 13064
[ 4] 6.00-7.00 sec 17.4 MBytes 146 Mbits/sec 12584
[ 4] 7.00-8.00 sec 16.8 MBytes 141 Mbits/sec 12141
[ 4] 8.00-9.00 sec 16.8 MBytes 141 Mbits/sec 12201
[ 4] 9.00-10.00 sec 17.2 MBytes 144 Mbits/sec 12442
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bandwidth Jitter Lost/Total Datagrams
[ 4] 0.00-10.00 sec 175 MBytes 147 Mbits/sec 0.100 ms 0/126526 (0%)
[ 4] Sent 126526 datagrams

4.12.0 (TCP; no patch)

% iperf3 -c remote
Connecting to host remote, port 5201
[ 4] local local port 50394 connected to remote port 5201
[ ID] Interval Transfer Bandwidth Retr Cwnd
[ 4] 0.00-1.00 sec 2.37 MBytes 19.9 Mbits/sec 0 29.7 KBytes
[ 4] 1.00-2.00 sec 2.53 MBytes 21.2 Mbits/sec 0 29.7 KBytes
[ 4] 2.00-3.00 sec 2.43 MBytes 20.4 Mbits/sec 0 29.7 KBytes
[ 4] 3.00-4.00 sec 2.52 MBytes 21.2 Mbits/sec 0 29.7 KBytes
[ 4] 4.00-5.00 sec 2.53 MBytes 21.2 Mbits/sec 0 29.7 KBytes
[ 4] 5.00-6.00 sec 2.55 MBytes 21.4 Mbits/sec 0 29.7 KBytes
[ 4] 6.00-7.00 sec 2.55 MBytes 21.4 Mbits/sec 0 29.7 KBytes
[ 4] 7.00-8.00 sec 2.48 MBytes 20.8 Mbits/sec 0 29.7 KBytes
[ 4] 8.00-9.00 sec 2.55 MBytes 21.4 Mbits/sec 0 29.7 KBytes
[ 4] 9.00-10.00 sec 2.47 MBytes 20.7 Mbits/sec 0 29.7 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bandwidth Retr
[ 4] 0.00-10.00 sec 25.0 MBytes 21.0 Mbits/sec 0 sender
[ 4] 0.00-10.00 sec 25.0 MBytes 20.9 Mbits/sec receiver

4.12.0 (TCP; _with_ patch)
+ limit = max(2 * skb->truesize, sk->sk_pacing_rate >> 8);

% iperf3 -c remote
Connecting to host remote, port 5201
[ 4] local local port 59780 connected to remote port 5201
[ ID] Interval Transfer Bandwidth Retr Cwnd
[ 4] 0.00-1.00 sec 13.4 MBytes 113 Mbits/sec 0 181 KBytes
[ 4] 1.00-2.00 sec 16.9 MBytes 142 Mbits/sec 0 216 KBytes
[ 4] 2.00-3.00 sec 16.7 MBytes 140 Mbits/sec 0 252 KBytes
[ 4] 3.00-4.00 sec 17.2 MBytes 145 Mbits/sec 0 280 KBytes
[ 4] 4.00-5.00 sec 17.4 MBytes 146 Mbits/sec 0 317 KBytes
[ 4] 5.00-6.00 sec 16.9 MBytes 142 Mbits/sec 0 332 KBytes
[ 4] 6.00-7.00 sec 17.7 MBytes 149 Mbits/sec 0 332 KBytes
[ 4] 7.00-8.00 sec 18.2 MBytes 153 Mbits/sec 0 386 KBytes
[ 4] 8.00-9.00 sec 17.9 MBytes 150 Mbits/sec 0 386 KBytes
[ 4] 9.00-10.00 sec 17.3 MBytes 145 Mbits/sec 0 386 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bandwidth Retr
[ 4] 0.00-10.00 sec 170 MBytes 142 Mbits/sec 0 sender
[ 4] 0.00-10.00 sec 169 MBytes 142 Mbits/sec receiver

4.12.0 (TCP; _with_ patch)
+ limit = max(4 * skb->truesize, sk->sk_pacing_rate >> 7);

% iperf3 -c remote
Connecting to host remote, port 5201
[ 4] local local port 55672 connected to remote port 5201
[ ID] Interval Transfer Bandwidth Retr Cwnd
[ 4] 0.00-1.00 sec 12.5 MBytes 105 Mbits/sec 2 132 KBytes
[ 4] 1.00-2.00 sec 17.3 MBytes 145 Mbits/sec 0 181 KBytes
[ 4] 2.00-3.00 sec 18.1 MBytes 152 Mbits/sec 0 211 KBytes
[ 4] 3.00-4.00 sec 18.6 MBytes 156 Mbits/sec 0 225 KBytes
[ 4] 4.00-5.00 sec 17.9 MBytes 151 Mbits/sec 0 242 KBytes
[ 4] 5.00-6.00 sec 17.0 MBytes 142 Mbits/sec 0 253 KBytes
[ 4] 6.00-7.00 sec 17.5 MBytes 146 Mbits/sec 0 262 KBytes
[ 4] 7.00-8.00 sec 18.5 MBytes 155 Mbits/sec 0 269 KBytes
[ 4] 8.00-9.00 sec 17.9 MBytes 150 Mbits/sec 0 272 KBytes
[ 4] 9.00-10.00 sec 18.0 MBytes 151 Mbits/sec 0 277 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bandwidth Retr
[ 4] 0.00-10.00 sec 173 MBytes 145 Mbits/sec 2 sender
[ 4] 0.00-10.00 sec 173 MBytes 145 Mbits/sec receiver

[end]