Tested this in a PPA, and it works as expected. One minor issue is that when uninstalling the communitheme snap while the theme is in use, icons in the dock change on the fly, and that doesn't look great. That would happen only during upgrade from bionic and to users actually using the communitheme session, so that's probably acceptable, but we can reduce the impact further by having the snap removed in the dist-upgrader code at the very end of the upgrade process (when unused debs are being removed).
And the session files (/usr/share/xsessions/ubuntu-communitheme-snap.desktop and /usr/share/wayland-sessions/ubuntu-communitheme-snap-wayland.desktop) installed by ubuntu-session should move to a separate binary package and be removed when upgrading.
Tested this in a PPA, and it works as expected. One minor issue is that when uninstalling the communitheme snap while the theme is in use, icons in the dock change on the fly, and that doesn't look great. That would happen only during upgrade from bionic and to users actually using the communitheme session, so that's probably acceptable, but we can reduce the impact further by having the snap removed in the dist-upgrader code at the very end of the upgrade process (when unused debs are being removed).
And the session files (/usr/share/ xsessions/ ubuntu- communitheme- snap.desktop and /usr/share/ wayland- sessions/ ubuntu- communitheme- snap-wayland. desktop) installed by ubuntu-session should move to a separate binary package and be removed when upgrading.