Ubuntu
xserver-xorg-input-synaptics package

  1. Bug #795920
  2. Comment #17

Comment 17 for bug 795920

Revision history for this message
In , Peter Hutterer (peter-hutterer) wrote :

(In reply to comment #10)
> Would a patch be less likely to be accepted if it doesn't separate the LED
> support from the disable support?

yes. I don't want crazy in-driver functionality for touchpads that don't need it. There should be discovery of that feature and it should only be exposed when the LED is available.

note that we'll likely need to query the LED state as well to avoid getting the touchpad into an inconsistent state (disabled, when it's actually enabled etc.)

looking through linux/input.h, we should send KEY_TOUCHPAD_ON/OFF when that button is pressed. The clients can then decide what to do, rather than having this behaviour enforced in the driver.