UCUnits::resolveResource takes up to 23% of unity8-dash's CPU time when scrolling a long scope
Bug #1604029 reported by
Albert Astals Cid
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Albert Astals Cid |
Bug Description
According to the attached callgrind trace (obtaining scrolling up/down the fake_ubrick_scope) one can see that calls to Image item setSource end up intercepted by UCQQuickImageEx
That takes 23% of the total CPU time looking for which file to actually open.(which is the given path since there's no @GU files at all)
Related branches
lp://staging/~aacid/ubuntu-ui-toolkit/prefer_image_if_it_exists
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
- Andrea Bernabei (community): Approve
-
Diff: 55 lines (+11/-12)1 file modifiedsrc/Ubuntu/UbuntuToolkit/ucunits.cpp (+11/-12)
description: | updated |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Albert Astals Cid (aacid) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
tags: | added: unity8-desktop |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
summary: |
- UCUnits::resolveResource takes up to 23% of CPU time when scrolling a - long Unity8-dash Scope + UCUnits::resolveResource takes up to 23% of unity8-dash's CPU time when + scrolling a long scope |
Changed in canonical-devices-system-image: | |
milestone: | none → 13 |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I have no magic fix for this though, suggestions include:
* Remove this fuzzy matching of filenames
* Somehow give the hability of opting out of this fuzzy filename matching
* Caching the last X dirs, so at least repeat queries (like going up/down the same scope) are a bit faster.