null initializer properties handed over to AdaptivePageLayout or PageStack page adding functions cause error
Bug #1604780 reported by
Zsombor Egri
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
Bug Description
If a page is added to AdaptivePageLayout or PageStack with an initializer list, where an initial value is set to null, the null value causes "Cannot convert to QVariant::<type*> from QVariant::void*" error to be shown. The error is provided by the PageWrapper 1.3 implementation.
This works with 1.2 PageStack and PageWrapper (all QML).
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/thereAreOtherStarsToo
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 94 lines (+77/-2)2 files modifiedsrc/Ubuntu/UbuntuToolkit/privates/ucpagewrapper.cpp (+15/-2)
tests/unit/visual/tst_adaptivepagelayout_param.13.qml (+62/-0)
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/saferString
- Zoltan Balogh: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/Ubuntu/UbuntuToolkit/privates/ucpagewrapper.cpp (+1/-1)
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → In Progress |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| milestone: | none → 13 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2060+
---------------
ubuntu-ui-toolkit (1.3.2060+
[ Zoltan Balogh ]
* Fix OptionSelectorT
* Fix more OptionSelector autopilot tests
[ Timo Jyrinki ]
* Disable documentation building for GLES builds. Fixes LP: #1606222.
* Replace abs with qFabs due to GCC6 breakage. Fixes LP: #1610943.
* Limit s390x dependencies more due to upstart/s390x problems and removed
packages in archives. Fixes LP: #1610951
[ Andrea Bernabei ]
* ListItemLayout doc: add elide mode change example and add section about
labels default properties values. Fixes LP: #1603450.
* ListItemLayout doc: add explicit note about the need to bind ListItem's
height to layout's height.
* More Scrollbar optimizations: 20% faster creation time. Fixes LP: #1606451
* Scrollbar: fix wrong thumb color on tap/mouse release and increase coverage
of hover states unit tests. Fixes LP: #1608897
[ Zsombor Egri ]
* Fix null pointer property initializer used with 1.3 PageWrapper.
Fixes LP: #1604780.
* Fix BottomEdge content URL preloading. Fixes LP: #1604509.
[Albert Astals Cid ]
* UCUnits:
searching the disk for @gu images, which is a big speedup. According to
callgrind loading 100 images from a folder that contains 380 images goes
from around 3 million instructions per UCUnits:
to around 10 thousand. This optimization is ok since it is not correct to
ship both image.png and image@20.png. You either have to ship gu-enabled
files or not, but mixing them is not allowed. Searched for cases in which
that may be happening in my phone and found none. Fixes LP: #1604029.
[ Tim Peeters ]
* Configure colors of the buttons in the ActionBar and PageHeader through
their Styles. Fixes LP: #1597774.
* Fix assigning of constant values to a grouped property in StyleHints.
Fixes LP: #1602836.
* Fix list view keyboard navigation for RightToLeft and BottomToTop
directions. Fixes LP: #1605634
* Use external QML files instead of embedded QML strings for autopilot tests.
Fixes LP: #1578319
* Fix failing autopilot header tests.
* Fix ActionSelection
[Christian Dywan ]
* Include indexes in "offline" docs and filter out link errors.
Fixes LP: #1603937.
* Increase focus ring thickness from 1dp to 2dp. Fixes LP: #1602690.
* Add a snippet about tests to the toplevel README
* Enter/Return to trigger, Space to expand ComboButton. Fixes LP: #1523817.
* Initialize engine variable before using it in the _engine case.
* Use Qt.rgba instead of #0000 checking ListItem default color.
Fixes LP: #1560004
* Don't use a different .desktop file in the gallery tests.
Fixes LP: #1578319
* Update scaling docs, set QT_SCALE_FACTOR and unset GRID_UNIT_PX.
Fixes LP: #1610208
[ Florian Boucault ]
* Sections: load Icons asynchronously.
-- Zoltán Balogh <email address hidden> Sun, 14 Aug 2016 09:06:46 +0000